Skip to content

Commit e98554f

Browse files
authored
Pin v8 version used in testing. NFC (#17847)
test_async_hello_stack_switching fails under 10.7.187 and above.
1 parent cdbbefa commit e98554f

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.circleci/config.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ executors:
1717
EMTEST_WASI_SYSROOT: "~/wasi-sdk/wasi-sysroot"
1818
EMTEST_BUILD_VERBOSE: "2"
1919
EMTEST_DETECT_TEMPFILE_LEAKS: "1"
20+
# Currently pinned due to https://github.com/emscripten-core/emscripten/issues/17846
21+
V8_VERSION: "10.7.186"
2022
mac:
2123
environment:
2224
EMSDK_NOTTY: "1"
@@ -82,7 +84,7 @@ commands:
8284
# as a "bleeding edge" shell here, basically, with node being the
8385
# primary shell (which we run without any special flags)
8486
# Refer to commit 0bc3640 if we need to pin V8 version.
85-
echo "V8_ENGINE = [os.path.expanduser('~/.jsvu/v8'), '--wasm-staging']" >> .emscripten
87+
echo "V8_ENGINE = [os.path.expanduser('~/.jsvu/v8-${V8_VERSION}'), '--wasm-staging']" >> .emscripten
8688
echo "JS_ENGINES = [NODE_JS]" >> .emscripten
8789
echo "if os.path.exists(V8_ENGINE[0]): JS_ENGINES.append(V8_ENGINE)" >> .emscripten
8890
echo "WASM_ENGINES = []" >> .emscripten
@@ -355,7 +357,7 @@ jobs:
355357
export PATH="`pwd`/node-v12.13.0-linux-x64/bin:${PATH}"
356358
npm install jsvu -g
357359
export PATH="${HOME}/.jsvu:${PATH}"
358-
jsvu --os=default --engines=v8
360+
jsvu --os=default --engines=v8 v8@${V8_VERSION}
359361
- build
360362
- build-libs
361363
- persist

0 commit comments

Comments
 (0)