[NFC] Strip the names section using llvm-objcopy in the metadce tests (#22220)

kripken · web-flow · commit ec2f28d5f5bb · 2024-07-10T12:32:31.000-07:00
This is more precise than using `wasm-opt`, as it literally just removes
the names section, and avoids any Binaryen roundtripping artifacts.

The improvements here are just the effects of removing those artifacts.
diff --git a/test/other/metadce/test_metadce_cxx_ctors1.size b/test/other/metadce/test_metadce_cxx_ctors1.size
@@ -1 +1 @@
-129525
+129522
diff --git a/test/other/metadce/test_metadce_cxx_ctors2.size b/test/other/metadce/test_metadce_cxx_ctors2.size
@@ -1 +1 @@
-128971
+128968
diff --git a/test/other/metadce/test_metadce_cxx_except.size b/test/other/metadce/test_metadce_cxx_except.size
@@ -1 +1 @@
-171449
+171440
diff --git a/test/other/metadce/test_metadce_cxx_except_wasm.size b/test/other/metadce/test_metadce_cxx_except_wasm.size
@@ -1 +1 @@
-142589
+142580
diff --git a/test/other/metadce/test_metadce_cxx_except_wasm_exnref.size b/test/other/metadce/test_metadce_cxx_except_wasm_exnref.size
@@ -1 +1 @@
-145226
+145217
diff --git a/test/other/metadce/test_metadce_cxx_mangle.size b/test/other/metadce/test_metadce_cxx_mangle.size
@@ -1 +1 @@
-233002
+232993
diff --git a/test/other/metadce/test_metadce_cxx_noexcept.size b/test/other/metadce/test_metadce_cxx_noexcept.size
@@ -1 +1 @@
-132337
+132328
diff --git a/test/other/metadce/test_metadce_cxx_wasmfs.size b/test/other/metadce/test_metadce_cxx_wasmfs.size
@@ -1 +1 @@
-169604
+169591
diff --git a/test/other/metadce/test_metadce_files_js_fs.size b/test/other/metadce/test_metadce_files_js_fs.size
@@ -1 +1 @@
-392
+389
diff --git a/test/other/metadce/test_metadce_files_wasmfs.size b/test/other/metadce/test_metadce_files_wasmfs.size
@@ -1 +1 @@
-51021
+51018
diff --git a/test/other/metadce/test_metadce_hello_O0.size b/test/other/metadce/test_metadce_hello_O0.size
@@ -1 +1 @@
-14459
+14456
diff --git a/test/other/metadce/test_metadce_hello_O1.size b/test/other/metadce/test_metadce_hello_O1.size
@@ -1 +1 @@
-2463
+2460
diff --git a/test/other/metadce/test_metadce_hello_O2.size b/test/other/metadce/test_metadce_hello_O2.size
@@ -1 +1 @@
-2050
+2047
diff --git a/test/other/metadce/test_metadce_hello_O3.size b/test/other/metadce/test_metadce_hello_O3.size
@@ -1 +1 @@
-1744
+1741
diff --git a/test/other/metadce/test_metadce_hello_Os.size b/test/other/metadce/test_metadce_hello_Os.size
@@ -1 +1 @@
-1735
+1732
diff --git a/test/other/metadce/test_metadce_hello_Oz.size b/test/other/metadce/test_metadce_hello_Oz.size
@@ -1 +1 @@
-1293
+1290
diff --git a/test/other/metadce/test_metadce_hello_dylink.size b/test/other/metadce/test_metadce_hello_dylink.size
@@ -1 +1 @@
-9358
+9355
diff --git a/test/other/metadce/test_metadce_hello_wasmfs.size b/test/other/metadce/test_metadce_hello_wasmfs.size
@@ -1 +1 @@
-1744
+1741
diff --git a/test/other/metadce/test_metadce_libcxxabi_message_O3.size b/test/other/metadce/test_metadce_libcxxabi_message_O3.size
@@ -1 +1 @@
-100
+97
diff --git a/test/other/metadce/test_metadce_libcxxabi_message_O3_standalone.size b/test/other/metadce/test_metadce_libcxxabi_message_O3_standalone.size
@@ -1 +1 @@
-180
+177
diff --git a/test/other/metadce/test_metadce_mem_O3.size b/test/other/metadce/test_metadce_mem_O3.size
@@ -1 +1 @@
-5268
+5265
diff --git a/test/other/metadce/test_metadce_mem_O3_grow.size b/test/other/metadce/test_metadce_mem_O3_grow.size
@@ -1 +1 @@
-5269
+5266
diff --git a/test/other/metadce/test_metadce_mem_O3_grow_standalone.size b/test/other/metadce/test_metadce_mem_O3_grow_standalone.size
@@ -1 +1 @@
-5592
+5589
diff --git a/test/other/metadce/test_metadce_mem_O3_standalone.size b/test/other/metadce/test_metadce_mem_O3_standalone.size
@@ -1 +1 @@
-5517
+5514
diff --git a/test/other/metadce/test_metadce_mem_O3_standalone_lib.size b/test/other/metadce/test_metadce_mem_O3_standalone_lib.size
@@ -1 +1 @@
-5280
+5277
diff --git a/test/other/metadce/test_metadce_mem_O3_standalone_narg.size b/test/other/metadce/test_metadce_mem_O3_standalone_narg.size
@@ -1 +1 @@
-5310
+5307
diff --git a/test/other/metadce/test_metadce_mem_O3_standalone_narg_flto.size b/test/other/metadce/test_metadce_mem_O3_standalone_narg_flto.size
@@ -1 +1 @@
-4127
+4124
diff --git a/test/test_other.py b/test/test_other.py
@@ -8499,7 +8499,7 @@ def run_metadce_test(self, filename, args=[], expected_exists=[], expected_not_e
 
     if check_size:
       # measure the wasm size without the name section
-      self.run_process([wasm_opt, 'a.out.wasm', '--strip-debug', '--all-features', '-o', 'a.out.nodebug.wasm'])
+      building.strip('a.out.wasm', 'a.out.nodebug.wasm', sections=['name'])
       wasm_size = os.path.getsize('a.out.nodebug.wasm')
       size_file = expected_basename + '.size'
       js_size = os.path.getsize('a.out.js')
