Apply suggestions from code review

Author: cclauss

tools/link.py

@@ -216,7 +216,8 @@ def get_js_sym_info():
   # and can contain full paths to temporary files.
   skip_settings = {'PRE_JS_FILES', 'POST_JS_FILES'}
   input_files = [json.dumps(settings.external_dict(skip_keys=skip_settings), sort_keys=True, indent=2)]
-  input_files.extend(read_file(jslib) for jslib in sorted(glob.glob(utils.path_from_root('src') + '/library*.js')))
+  jslibs = glob.glob(utils.path_from_root('src') + '/library*.js')
+  input_files.extend(read_file(jslib) for jslib in sorted(jslibs))
   for jslib in settings.JS_LIBRARIES:
     if not os.path.isabs(jslib):
       jslib = utils.path_from_root('src', jslib)

tools/maint/gen_sig_info.py

@@ -181,7 +181,7 @@ def ignore_symbol(s, cxx):
            'stackSave', 'stackRestore', 'stackAlloc', 'getTempRet0', 'setTempRet0',
            }:
     return True
-  return bool(cxx and s == '__asctime_r' or s.startswith('__cxa_find_matching_catch'))
+  return cxx and s == '__asctime_r' or s.startswith('__cxa_find_matching_catch')
 
 
 def create_c_file(filename, symbol_list, header):

tools/ports/__init__.py

@@ -326,7 +326,7 @@ def unpack():
       utils.write_file(marker, url + '\n')
 
     def up_to_date():
-      return bool(os.path.exists(marker) and utils.read_file(marker).strip() == url)
+      return os.path.exists(marker) and utils.read_file(marker).strip() == url
 
     # before acquiring the lock we have an early out if the port already exists
     if up_to_date():

tools/ports/bullet.py

@@ -32,7 +32,10 @@ def create(final):
         shared.safe_ensure_dirs(os.path.dirname(target))
         shutil.copyfile(fullpath, target)
 
-    includes = [os.path.join(base, dir) for base, dirs, _ in os.walk(src_path, topdown=False) for dir in dirs]
+    includes = []
+    for base, dirs, _ in os.walk(src_path, topdown=False):
+      for dir in dirs:
+        includes.append(os.path.join(base, dir))
 
     flags = [
       '-Wno-single-bit-bitfield-constant-conversion',