Avoid assignment to undefined variable in file_packager.py generated code (#5341)

Daft-Freak · kripken · commit f2bbd32e4bf7 · 2017-06-26T10:09:22.000-07:00
diff --git a/tools/file_packager.py b/tools/file_packager.py
@@ -467,7 +467,7 @@ def was_seen(name):
         }
 ''', create_preloaded if use_preload_plugins else create_data, '''
         var files = metadata.files;
-        for (i = 0; i < files.length; ++i) {
+        for (var i = 0; i < files.length; ++i) {
           new DataRequest(files[i].start, files[i].end, files[i].crunched, files[i].audio).open('GET', files[i].filename);
         }
 ''' if not lz4 else '')
@@ -524,7 +524,7 @@ def was_seen(name):
   '''
     use_data += '''
           var files = metadata.files;
-          for (i = 0; i < files.length; ++i) {
+          for (var i = 0; i < files.length; ++i) {
             DataRequest.prototype.requests[files[i].filename].onload();
           }
     '''

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,7 @@ def was_seen(name):`
`467`	`467`	`}`
`468`	`468`	`''', create_preloaded if use_preload_plugins else create_data, '''`
`469`	`469`	`var files = metadata.files;`
`470`		`- for (i = 0; i < files.length; ++i) {`
	`470`	`+ for (var i = 0; i < files.length; ++i) {`
`471`	`471`	`new DataRequest(files[i].start, files[i].end, files[i].crunched, files[i].audio).open('GET', files[i].filename);`
`472`	`472`	`}`
`473`	`473`	`''' if not lz4 else '')`
`@@ -524,7 +524,7 @@ def was_seen(name):`
`524`	`524`	`'''`
`525`	`525`	`use_data += '''`
`526`	`526`	`var files = metadata.files;`
`527`		`- for (i = 0; i < files.length; ++i) {`
	`527`	`+ for (var i = 0; i < files.length; ++i) {`
`528`	`528`	`DataRequest.prototype.requests[files[i].filename].onload();`
`529`	`529`	`}`
`530`	`530`	`'''`