Skip to content

Commit f4a5267

Browse files
authored
Fix reference for undefined errback. NFC (#24886)
This went unnoticed by the tests because the calling code has a `.catch` handler that calls the fallback function. So the test still passed but with a bunch of extra output: ``` ReferenceError: errback is not defined at openDatabase (/usr/local/google/home/sbc/dev/wasm/emscripten/out/test/src.js:173:13) at runWithFS (/usr/local/google/home/sbc/dev/wasm/emscripten/out/test/src.js:333:9) at callRuntimeCallbacks (/usr/local/google/home/sbc/dev/wasm/emscripten/out/test/src.js:1164:26) at preRun (/usr/local/google/home/sbc/dev/wasm/emscripten/out/test/src.js:841:3) at run (/usr/local/google/home/sbc/dev/wasm/emscripten/out/test/src.js:4658:3) at Object.removeRunDependency (/usr/local/google/home/sbc/dev/wasm/emscripten/out/test/src.js:950:7) at loadPackage (/usr/local/google/home/sbc/dev/wasm/emscripten/out/test/src.js:362:34) at runMetaWithFS (/usr/local/google/home/sbc/dev/wasm/emscripten/out/test/src.js:371:18) falling back to default preload behavior done ``` Followup to #24883
1 parent 03f6d1a commit f4a5267

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/file_packager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -807,7 +807,7 @@ def generate_js(data_target, data_files, metadata):
807807
var PACKAGE_STORE_NAME = 'PACKAGES';
808808
async function openDatabase() {
809809
if (typeof indexedDB == 'undefined') {
810-
return errback('using IndexedDB to cache data can only be done on a web page or in a web worker');
810+
throw 'using IndexedDB to cache data can only be done on a web page or in a web worker';
811811
}
812812
return new Promise((resolve, reject) => {
813813
var openRequest = indexedDB.open(DB_NAME, DB_VERSION);

0 commit comments

Comments
 (0)