fix pipeline

Author: lkwinta

tools/file_packager.py

@@ -924,7 +924,8 @@ def generate_js(data_target, data_files, metadata):
             var getRequest = packages.get(`package/${packageName}/${chunkId}`);
             getRequest.onsuccess = (event) => {
               if (!event.target.result) {
-                return errback(new Error(`CachedPackageNotFound for: ${packageName}`));
+                errback(new Error(`CachedPackageNotFound for: ${packageName}`));
+                return;
               }
               // If there's only 1 chunk, there's nothing to concatenate it with so we can just return it now
               if (chunkCount == 1) {
@@ -963,7 +964,7 @@ def generate_js(data_target, data_files, metadata):
         if (isNode) {
           require('fs').readFile(packageName, (err, contents) => {
             if (err) {
-              return errback(err);
+              errback(err);
             } else {
               callback(contents.buffer);
             }
@@ -1117,7 +1118,7 @@ def generate_js(data_target, data_files, metadata):
         if (isNode) {
           require('fs').readFile(metadataUrl, 'utf8', (err, contents) => {
             if (err) {
-              return handleError(err);
+              throwPackageError(err);
             } else {
               loadPackage(JSON.parse(contents));
             }
@@ -1139,9 +1140,9 @@ def generate_js(data_target, data_files, metadata):
           return response.json();
         }
       })
-      .catch((cause) => {
-        return handleError(new Error(`Network Error: ${packageName}`, {cause})
-      })) // If fetch fails, rewrite the error to include the failing URL & the cause.
+      .catch((cause) =>
+        throwPackageError(new Error(`Network Error: ${packageName}`, {cause}))
+      ) // If fetch fails, rewrite the error to include the failing URL & the cause.
       .then(loadPackage);
   }