Ensure ENVIRONMENT_IS_PTHREAD/WASM_WORKER are defined before pre-js file (#21721)

Its useful for pre-js files to be able to depend on these variables,
and this is specifically necessary for #21701 which removes the default
export of `ENVIRONMENT_IS_PTHREAD`.

Note that this also fixes an inconsistency between the regular runtime
and the minimal runtime where minimal runtime was defining some
`ENVIRONMENT_IS_XX` var before pre-js but the regular runtime was not.

Author: sbc100

src/runtime_debug.js

@@ -165,7 +165,7 @@ function dbg(...args) {
 #if ENVIRONMENT_MAY_BE_NODE && PTHREADS
   // Avoid using the console for debugging in multi-threaded node applications
   // See https://github.com/emscripten-core/emscripten/issues/14804
-  if (ENVIRONMENT_IS_NODE) {
+  if (ENVIRONMENT_IS_NODE && fs) {
     fs.writeSync(2, args.join(' ') + '\n');
   } else
 #endif

src/shell.js

@@ -75,23 +75,6 @@ var readyPromise = new Promise((resolve, reject) => {
 #endif
 #endif
 
-// --pre-jses are emitted after the Module integration code, so that they can
-// refer to Module (if they choose; they can also define Module)
-{{{ preJS() }}}
-
-// Sometimes an existing Module object exists with properties
-// meant to overwrite the default module functionality. Here
-// we collect those properties and reapply _after_ we configure
-// the current environment's defaults to avoid having to be so
-// defensive during initialization.
-var moduleOverrides = Object.assign({}, Module);
-
-var arguments_ = [];
-var thisProgram = './this.program';
-var quit_ = (status, toThrow) => {
-  throw toThrow;
-};
-
 // Determine the runtime environment we are in. You can customize this by
 // setting the ENVIRONMENT setting at compile time (see settings.js).
 
@@ -143,6 +126,23 @@ var ENVIRONMENT_IS_PTHREAD = Module['ENVIRONMENT_IS_PTHREAD'] || false;
 var ENVIRONMENT_IS_WASM_WORKER = Module['$ww'];
 #endif
 
+// --pre-jses are emitted after the Module integration code, so that they can
+// refer to Module (if they choose; they can also define Module)
+{{{ preJS() }}}
+
+// Sometimes an existing Module object exists with properties
+// meant to overwrite the default module functionality. Here
+// we collect those properties and reapply _after_ we configure
+// the current environment's defaults to avoid having to be so
+// defensive during initialization.
+var moduleOverrides = Object.assign({}, Module);
+
+var arguments_ = [];
+var thisProgram = './this.program';
+var quit_ = (status, toThrow) => {
+  throw toThrow;
+};
+
 #if SHARED_MEMORY && !MODULARIZE
 // In MODULARIZE mode _scriptDir needs to be captured already at the very top of the page immediately when the page is parsed, so it is generated there
 // before the page load. In non-MODULARIZE modes generate it here.

src/shell_minimal.js

@@ -134,6 +134,18 @@ function ready() {
 #endif
 #endif
 
+#if PTHREADS
+// MINIMAL_RUNTIME does not support --proxy-to-worker option, so Worker and Pthread environments
+// coincide.
+#if WASM_WORKERS
+var ENVIRONMENT_IS_WORKER = typeof importScripts == 'function',
+  ENVIRONMENT_IS_PTHREAD = ENVIRONMENT_IS_WORKER && !ENVIRONMENT_IS_WASM_WORKER;
+#else
+var ENVIRONMENT_IS_WORKER = typeof importScripts == 'function',
+  ENVIRONMENT_IS_PTHREAD = ENVIRONMENT_IS_WORKER;
+#endif
+#endif
+
 // --pre-jses are emitted after the Module integration code, so that they can
 // refer to Module (if they choose; they can also define Module)
 {{{ preJS() }}}
@@ -146,16 +158,6 @@ function ready() {
 var _scriptDir = (typeof document != 'undefined') ? document.currentScript?.src : undefined;
 #endif
 
-// MINIMAL_RUNTIME does not support --proxy-to-worker option, so Worker and Pthread environments
-// coincide.
-#if WASM_WORKERS
-var ENVIRONMENT_IS_WORKER = typeof importScripts == 'function',
-  ENVIRONMENT_IS_PTHREAD = ENVIRONMENT_IS_WORKER && !ENVIRONMENT_IS_WASM_WORKER;
-#else
-var ENVIRONMENT_IS_WORKER = typeof importScripts == 'function',
-  ENVIRONMENT_IS_PTHREAD = ENVIRONMENT_IS_WORKER;
-#endif
-
 if (ENVIRONMENT_IS_WORKER) {
   _scriptDir = self.location.href;
 }

test/other/metadce/test_metadce_cxx_ctors1.gzsize

@@ -1 +1 @@
-9852
+9851

test/other/metadce/test_metadce_cxx_except.gzsize

@@ -1 +1 @@
-10942
+10941

test/other/metadce/test_metadce_cxx_noexcept.gzsize

@@ -1 +1 @@
-9852
+9851

test/other/metadce/test_metadce_cxx_wasmfs.gzsize

@@ -1 +1 @@
-5214
+5212

test/other/metadce/test_metadce_files_wasmfs.gzsize

@@ -1 +1 @@
-3134
+3133

test/other/metadce/test_metadce_hello_O0.gzsize

@@ -1 +1 @@
-8159
+8162

test/other/metadce/test_metadce_hello_O1.gzsize

@@ -1 +1 @@
-2975
+2974