Skip to content

Commit f9a781b

Browse files
committed
Try dummy audio for FF; remove LACKS_SOUND_HARDWARE
1 parent 9bcf181 commit f9a781b

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

.circleci/config.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -306,15 +306,16 @@ commands:
306306
- run:
307307
name: run tests (<< parameters.title >>)
308308
environment:
309-
EMTEST_LACKS_SOUND_HARDWARE: "1"
310309
EMTEST_DETECT_TEMPFILE_LEAKS: "0"
311310
# --no-sandbox because we are running as root and chrome requires
312311
# this flag for now: https://crbug.com/638180
313312
CHROME_FLAGS_BASE: "--no-first-run -start-maximized --no-sandbox --use-gl=swiftshader --user-data-dir=/tmp/chrome-emscripten-profile --enable-experimental-web-platform-features"
314313
CHROME_FLAGS_HEADLESS: "--headless=new --remote-debugging-port=1234"
315314
CHROME_FLAGS_WASM: "--enable-experimental-webassembly-features --js-flags=\"--experimental-wasm-stack-switching --experimental-wasm-type-reflection\""
316315
CHROME_FLAGS_NOCACHE: "--disk-cache-dir=/dev/null --disk-cache-size=1 --media-cache-size=1 --disable-application-cache --incognito"
317-
CHROME_FLAGS_AUDIO: "--autoplay-policy=no-user-gesture-required --use-fake-device-for-media-stream"
316+
# The runners lack sound hardware so fallback to a dummy device (and
317+
# bypass the user gesture so audio tests work without interaction)
318+
CHROME_FLAGS_AUDIO: " --use-fake-device-for-media-stream --autoplay-policy=no-user-gesture-required"
318319
command: |
319320
export EMTEST_BROWSER="/usr/bin/google-chrome $CHROME_FLAGS_BASE $CHROME_FLAGS_HEADLESS $CHROME_FLAGS_WASM $CHROME_FLAGS_NOCACHE $CHROME_FLAGS_AUDIO"
320321
# There are tests in the browser test suite that using libraries
@@ -361,6 +362,7 @@ commands:
361362
user_pref("javascript.options.shared_memory", true);
362363
user_pref("javascript.options.wasm_memory64", true);
363364
user_pref("dom.postMessage.sharedArrayBuffer.bypassCOOP_COEP.insecure.enabled", true);
365+
user_pref("media.navigator.streams.fake", true);
364366
user_pref("media.autoplay.default", 0);
365367
EOF
366368
- run:
@@ -371,11 +373,12 @@ commands:
371373
# support in headless mode) resolves
372374
EMTEST_LACKS_GRAPHICS_HARDWARE: "1"
373375
EMTEST_LACKS_WEBGPU: "1"
374-
EMTEST_LACKS_SOUND_HARDWARE: "1"
375376
# OffscreenCanvas support is not yet done in Firefox.
376377
EMTEST_LACKS_OFFSCREEN_CANVAS: "1"
377378
EMTEST_DETECT_TEMPFILE_LEAKS: "0"
378379
DISPLAY: ":0"
380+
# Note: as per Chrome, the FF profile enables a dummy audio device
381+
# (so doesn't need the EMTEST_LACKS_SOUND_HARDWARE var)
379382
command: |
380383
export EMTEST_BROWSER="$HOME/firefox/firefox -headless -profile $HOME/tmp-firefox-profile/"
381384
# There are tests in the browser test suite that using libraries

0 commit comments

Comments
 (0)