-
Notifications
You must be signed in to change notification settings - Fork 3.5k
WebGPU: use wasm-friendly overload of setBindGroup #21221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI @jimblandy. Supporting this is not urgent, but it should be more efficient than the old code. |
|
@kainino0x Which WebGPU API does this need from Firefox, specifically? |
|
Sorry, forgot the detail wasn't here. It's on the linked issue. This uses the overload of setBindGroup that takes a Firefox only seems to have the first one: |
|
Firefox work tracked here: https://bugzilla.mozilla.org/show_bug.cgi?id=1878804 This is not an immediate priority for us, but it's in the spec and we will get to it eventually. |
|
People are starting to run into some performance bottlenecks with setBindGroup, and this will help a little bit, so let's go ahead and do it. |
|
PTAL @lokokung |
|
This won't be fixed in Emscripten's current WebGPU bindings, but now that Firefox has been fixed, I'll finally fix this in |
This was fixed in Firefox, so now we can use it! Tested in my local sample project that this works in both Chrome and Firefox Nightly. Migrated from emscripten-core/emscripten#21221 No-Try: true Bug: emscripten-core/emscripten#20280 Change-Id: I0900e635a043413e516ec73b7de4978d4e574724 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/236936 Auto-Submit: Kai Ninomiya <[email protected]> Commit-Queue: Kai Ninomiya <[email protected]> Reviewed-by: Loko Kung <[email protected]>
Blocked on Firefox support.
Fixes #20280