Fix emrun sporadic exit hang on Windows #22577
Conversation
emrun.py
Outdated
| page_exit_code = int(data[6:]) | ||
| logv('Web page has quit with a call to exit() with return code ' + str(page_exit_code) + '. Shutting down web server. Pass --serve-after-exit to keep serving even after the page terminates with exit().') | ||
| if emrun_options.force_exit: | ||
| self.server.socket.setblocking(False) |
There was a problem hiding this comment.
Is there a downside to always doing this? I mean, instead of adding an option, to always set nonblocking after the page exits?
There was a problem hiding this comment.
From our side there is no downside specific to this change. We just thought that it might be categorically better received if it were presented as an option, but there is no downside to always doing this before shutdown.
There was a problem hiding this comment.
Ok, then I think it's better to avoid adding an option actually. That way it will be fully tested.
|
I wish I understood better the naunace of what is happening.. but I fear that might take an inordinate amount of time. No concerns if you are ok with it @kripken |
|
Yeah, I don't fully understand the deadlock either, but this seems harmless to do during shutdown anyhow, so since it fixes issues in practice on windows, let's land it. Thanks @rghosh0 ! |
3 participants
Fixes #22578 ("Windows: emrun.py does not exit as expected")
We set the server's socket itself to non-blocking before shutdown. This way the threads can still be joined and the ordinary and cleaner sys.exit(...) exit function can be used. Here is a diff that we propose to be adopted (which makes this behaviour a program option for emrun).