Fix combining of test parametization. NFC #22637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
commented
Sep 26, 2024
kripken
approved these changes
Sep 26, 2024
sbc100
force-pushed
the
test_parameterize
branch
from
18456e0 to
adc3153
Compare
As far as I can tell the only test that was relying on this features is `browser.test_sdl_image_prepare` which uses `@also_with_proxied` in addition to `@also_with_wasmfs` and it was getting the names and values backwards. I confirmed manually that all 4 test combination now do the right thing.
sbc100
force-pushed
the
test_parameterize
branch
from
adc3153 to
4c5837e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell the only test that was relying on this features is
browser.test_sdl_image_preparewhich uses@also_with_proxiedin addition to@also_with_wasmfsand it was getting the names and values backwards. I confirmed manually that all 4 test combination now do the right thing.