Error on wasm worker creation when SAB is not available #22720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
wasm_worker_error
branch
2 times, most recently
from
6666c8f to
e47df86
Compare
juj
reviewed
Oct 11, 2024
sbc100
force-pushed
the
wasm_worker_error
branch
from
b2eedf8 to
565737a
Compare
kripken
approved these changes
Oct 14, 2024
sbc100
force-pushed
the
wasm_worker_error
branch
from
565737a to
ba75a8d
Compare
Collaborator
Author
|
Lets land #22723 separately. |
This should have been part of emscripten-core#22710
sbc100
force-pushed
the
wasm_worker_error
branch
from
ba75a8d to
e097cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been part of #22710