Skip to content

[embind] Better reflect the actual class hierarchy in TS. #22734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brendandahl merged 2 commits into from
Oct 24, 2024
Merged

[embind] Better reflect the actual class hierarchy in TS. #22734

brendandahl merged 2 commits into from
Oct 24, 2024

Conversation

@brendandahl
Copy link
Collaborator

@brendandahl brendandahl commented Oct 14, 2024

  • All classes now extend from ClassHandle, which is what really happens in JS.
  • Add the missing methods that are available on ClassHandles.

Fixes #22701

@brendandahl
[embind] Better reflect the actual class hierarchy in TS.
1693f99 
 - All classes now extend from ClassHandle, which is what really
   happens in JS.
 - Add the missing methods that are available on ClassHandles.
@brendandahl brendandahl requested a review from sbc100 October 14, 2024 22:01
sbc100
sbc100 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@arnog-ms
Copy link

arnog-ms commented Oct 21, 2024 •
edited
Loading

I think deleteLater() returns a reference to the object itself, doesn't it? Otherwise you couldn't chain calls. So for the TypeScript definition the return type for deleteLater() should rather be this?

@brendandahl brendandahl merged commit 218195c into emscripten-core:main Oct 24, 2024
1 of 2 checks passed
@dschuff dschuff mentioned this pull request Oct 29, 2024
Merged
@dschuff dschuff mentioned this pull request Nov 15, 2024
Merged
vrabaud added a commit to vrabaud/opencv that referenced this pull request Dec 18, 2024
@vrabaud
Rename Mat::clone binding because it is used in Emscripten.
9010bd4 
This is in emscripten 3.1.71 and above, cf
emscripten-core/emscripten#22734
There was a temptative fix upstream to no avail:
emscripten-core/emscripten#23132
vrabaud added a commit to vrabaud/opencv that referenced this pull request Dec 18, 2024
@vrabaud
Rename Mat::clone binding because it is used in Emscripten.
773bd1a 
This is in emscripten 3.1.71 and above, cf
emscripten-core/emscripten#22734
There was a temptative fix upstream to no avail:
emscripten-core/emscripten#23132
@vrabaud vrabaud mentioned this pull request Dec 18, 2024
Merged
6 tasks
shyama7004 pushed a commit to shyama7004/opencv that referenced this pull request Jan 20, 2025
@vrabaud @shyama7004
Rename Mat::clone binding because it is used in Emscripten.
82fff32 
This is in emscripten 3.1.71 and above, cf
emscripten-core/emscripten#22734
There was a temptative fix upstream to no avail:
emscripten-core/emscripten#23132
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
@vrabaud @NanQin555
Rename Mat::clone binding because it is used in Emscripten.
6ec6675 
This is in emscripten 3.1.71 and above, cf
emscripten-core/emscripten#22734
There was a temptative fix upstream to no avail:
emscripten-core/emscripten#23132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add deleteLater() and setDelayFunction(...) to TypeScript definitions and make them official API

3 participants

@brendandahl @arnog-ms @sbc100