Update node canary #22832
Merged
Update node canary #22832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
approved these changes
Nov 1, 2024
kripken
reviewed
Nov 1, 2024
kripken
approved these changes
Nov 1, 2024
sbc100
force-pushed
the
update_node
branch
2 times, most recently
from
9e6ce62 to
8c1dc1f
Compare
kripken
approved these changes
Nov 4, 2024
sbc100
force-pushed
the
update_node
branch
2 times, most recently
from
a5bd5a0 to
b4e6a0e
Compare
This involved using toIndexType in a few more places due to recent wasm64 changes requiring BitInt in more places. Split out from emscripten-core#22773
Member
|
This seems to have broken the wasm64l tests on Chromium CI: https://ci.chromium.org/ui/p/emscripten-releases/builders/try/linux/b8732162502277725409/overview |
Member
|
Actually no, of course we shouldn't; the whole point of wasm64l is to work on MVP... |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 5, 2024
This was broken recently by emscripten-core#22832
Collaborator
Author
|
Fix is in #22853 |
dschuff
pushed a commit
that referenced
this pull request
Nov 5, 2024
This was broken recently by #22832
Member
|
Still seems broken? See https://chromium-review.googlesource.com/c/emscripten-releases/+/5995675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This involved using toIndexType in a few more places due to recent wasm64 changes requiring BitInt in more places.
Split out from #22773