[library_html5] Simplify JSEvent system. NFC #22849
Conversation
sbc100
force-pushed
the
shared_events
branch
5 times, most recently
from
1420cb7 to
6a42389
Compare
|
Sadly I don't think we have code size tests that cover library_html5 but I think this would be pretty good code size saving. |
|
For test_html5_mouse_closure we have: Before: After: So a slight regression sadly :( |
This change extracts a few helper function to make the JS event system smaller and more internally consistent. Firstly, we now use a single storage location for the event data pointer used in event callback. This is allocated on demand in `allocateEventStruct`. We then use a new `dispatchEvent` all the many loction that previously duplicated the event dispatching logic. In order to handler the 3 cases where we need to keep a copy of the last dispatched event we also have two new helpers: `getCachedEvent`, `cacheEvent`. These allocate separate copies of the last generated event, but only for the 3 event types where this is required.
|
This looks like a rather large refactoring, and I am worried about our lack of testing on this UI code. Are you certain we have coverage of all the things changed here? If not, perhaps before this PR we can look into adding tests? |
Agreed, I'll put this on ice until I get around to adding more testing. |
2 participants
This change extracts a few helper function to make the JS event system smaller and more internally consistent.
Firstly, we now use a single storage location for the event data pointer used in event callback. This is allocated on demand in
allocateEventStruct. We then use a newdispatchEventall the many loction that previously duplicated the event dispatching logic.In order to handler the 3 cases where we need to keep a copy of the last dispatched event we also have two new helpers:
getCachedEvent,cacheEvent. These allocate separate copies of the last generated event, but only for the 3 event types where this is required.