-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update website theme for newer Sphinx #15365 #22872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kripken
merged 12 commits into
emscripten-core:main
from
lorsanta:update-sphinx-rtd-theme
Nov 20, 2024
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3cd2b9a
Update website theme for newer Sphinx #15365
lorsanta 52467fb
fixes
lorsanta 3686624
Downgrade the Sphinx version from 8.1.3 to 7.1.2.
lorsanta ae6aa9f
fix search
lorsanta ae92a88
add Index to the side scroll
lorsanta 5b3d2f0
change permalinks icon by importing emscripten_sphinx_rtd_theme
lorsanta d25fae1
show logo on the navigation menu when mobile
lorsanta 2a2c4ac
update requirements-dev.txt
lorsanta 8988436
fix anchors issue
lorsanta 13d674f
remove sphinx dependencies
lorsanta 162fa7a
fix flake8 mypy failures
lorsanta 8286451
Merge branch 'main' into update-sphinx-rtd-theme
kripken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about if we simply remove all of these dependencies except for the sphinx one ones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that
sphinx 7.1.2hasjinja >= 3.0as a requirement.I think it's best to keep
jinja2==3.0to avoid future releases ofjinja2to break things.What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its best to only include direct dependencies here, up until the point where we have some reason to do otherwise.
But i'm no expert so if you think this is safer/better then I'm fine with it.
How about the rest of these indirect deps, can we remove those?