Use GLctx in library_egl.js and library_glut.js. NFC #22875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Nov 7, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Agreed, this is a good direction. Module.* for what could be a normal var is best replaced.
I'm trying to reduce/remove the usage of `Module.ctx` with a view to possibly removing it from the `Module` object. These usages should be using `GLctx` anyway I believe.
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 7, 2024
…#22875) I'm trying to reduce/remove the usage of `Module.ctx` with a view to possibly removing it from the `Module` object. These usages should be using `GLctx` anyway I believe.
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 15, 2024
…#22875) I'm trying to reduce/remove the usage of `Module.ctx` with a view to possibly removing it from the `Module` object. These usages should be using `GLctx` anyway I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to reduce/remove the usage of
Module.ctxwith a view to possibly removing it from theModuleobject. These usages should be usingGLctxanyway I believe.