Fix undefined behavior in test_int53 #22895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use uint64 for tests including values unrepresentable by i64
kripken
approved these changes
Nov 11, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm, but what is the specific UB fixed here?
Member
Author
|
The test uses numbers such as 0x8000000000000000ull but was converting to int64_t and overflowing, |
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 15, 2024
The test uses numbers such as 0x8000000000000000ull but was converting to int64_t and overflowing, leading to UB and different behavior when using saturating conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test uses numbers such as 0x8000000000000000ull but was converting to int64_t and overflowing,
leading to UB and different behavior when using saturating conversions.