Skip to content

support cmake LINK_LIBRARY:WHOLE_ARCHIVE #22975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 2, 2024
Merged

support cmake LINK_LIBRARY:WHOLE_ARCHIVE #22975

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
58bfad1
support cmake LINK_LIBRARY:WHOLE_ARCHIVE
eagleoflqj Nov 20, 2024
c17d2b3
add test
eagleoflqj Nov 23, 2024
ac93afb
Merge branch 'main' into whole-archive
eagleoflqj Nov 23, 2024
b16e887
address review comments
eagleoflqj Nov 24, 2024
c496181
skip test in test-other job
eagleoflqj Nov 28, 2024
9d23dad
Merge branch 'main' into whole-archive
eagleoflqj Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cmake/Modules/Platform/Emscripten.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,10 @@ set(CMAKE_CXX_USE_RESPONSE_FILE_FOR_INCLUDES 1)
set(CMAKE_C_RESPONSE_FILE_LINK_FLAG "@")
set(CMAKE_CXX_RESPONSE_FILE_LINK_FLAG "@")

# Enable $<LINK_LIBRARY:WHOLE_ARCHIVE,static_lib> for CMake 3.24+
set(CMAKE_LINK_LIBRARY_USING_WHOLE_ARCHIVE "-Wl,--whole-archive" "<LINK_ITEM>" "-Wl,--no-whole-archive")
set(CMAKE_LINK_LIBRARY_USING_WHOLE_ARCHIVE_SUPPORTED True)

# Set a global EMSCRIPTEN variable that can be used in client CMakeLists.txt to
# detect when building using Emscripten.
set(EMSCRIPTEN 1 CACHE INTERNAL "If true, we are targeting Emscripten output.")
Expand Down
Loading