Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 21, 2024

See #22964

Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we raced with #22891, either one is fine with me.

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 21, 2024

Looks like we raced with #22891, either one is fine with me.

I don't think your PR actually works because there is no tool called just "rust", its either "cargo" or "rustc", but since the tool we use directly is "cargo" I figured its better to use that?

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 21, 2024

Tested locally, so landing without waiting for CI so we can get the roller running again.

@sbc100 sbc100 merged commit bd2de9c into emscripten-core:main Nov 21, 2024
4 of 13 checks passed
@sbc100 sbc100 deleted the rust_name branch November 21, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants