Use octal JS literals. NFC #23022
Merged
Use octal JS literals. NFC #23022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Nov 27, 2024
src/library_lz4.js
Outdated
| $LZ4: { | ||
| DIR_MODE: {{{ cDefs.S_IFDIR }}} | 511 /* 0777 */, | ||
| FILE_MODE: {{{ cDefs.S_IFREG }}} | 511 /* 0777 */, | ||
| DIR_MODE: {{{ cDefs.S_IFDIR }}} | 0o777, |
There was a problem hiding this comment.
Does closure optimize this? The octal notation is easier to read but it is larger.
There was a problem hiding this comment.
The acorn optimizer might also optimize this, maybe just by default, if it doesn't track what was octal originally and preserve it?
There was a problem hiding this comment.
Yes, which ever layer it is that converts this to a normal number, it is happening since this change has zero code size changes.
sbc100
force-pushed
the
octals
branch
2 times, most recently
from
86d0fda to
f3ed0f4
Compare
kripken
approved these changes
Nov 27, 2024
Followup to emscripten-core#23014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #23014