Use preset to set doesNotExistError instead of postset. NFC #23026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we throw `MEMFS.doesNotExistError` before it is initialized. It doesn't really matter because the error gets caught and thrown away, but it seems better to fix.
sbc100
reviewed
Nov 27, 2024
| addToLibrary({ | ||
| $MEMFS__deps: ['$FS', '$mmapAlloc'], | ||
| #if !ASSERTIONS | ||
| $MEMFS__postset: ` |
There was a problem hiding this comment.
Can you explain how MEMFS.doesNotExistError could get used before the postset run? IIUC the post set code is emitted at the top level at the end of the library top level code. Is the problem that other postset code wants to run first?
Wouldn't preset attempt to set MEMFS.doesNotExistError before MEMFS itself is created?
There was a problem hiding this comment.
Actually __preset just doesn't exist. Only __postset. So I'm not sure how this could work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we throw
MEMFS.doesNotExistErrorbefore it is initialized. It doesn't really matter because theundefinedwe throw gets caught and thrown away, but it seems better to fix.