Skip to content

Remove unnecessary forced exports. NFC #23060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Remove unnecessary forced exports. NFC #23060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/library_pthread.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ var LibraryPThread = {
},

$establishStackSpace__internal: true,
$establishStackSpace__deps: ['$stackRestore'],
$establishStackSpace__deps: ['$stackRestore', 'emscripten_stack_set_limits'],
$establishStackSpace: (pthread_ptr) => {
#if ALLOW_MEMORY_GROWTH
// If memory growth is enabled, the memory views may have gotten out of date,
Expand Down
1 change: 0 additions & 1 deletion test/other/codesize/test_codesize_minimal_pthreads.funcs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ $em_task_queue_free
$em_task_queue_is_empty
$emscripten_builtin_free
$emscripten_builtin_malloc
$emscripten_current_thread_process_queued_calls
$emscripten_futex_wait
$emscripten_futex_wake
$emscripten_stack_get_current
Expand Down
2 changes: 1 addition & 1 deletion test/other/codesize/test_codesize_minimal_pthreads.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
19501
19495
5 changes: 1 addition & 4 deletions tools/link.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,10 +499,6 @@ def setup_pthreads():
settings.REQUIRED_EXPORTS += [
'_emscripten_thread_free_data',
'_emscripten_thread_crashed',
'emscripten_main_runtime_thread_id',
'emscripten_main_thread_process_queued_calls',
'_emscripten_run_on_main_thread_js',
'emscripten_stack_set_limits',
]

if settings.EMBIND:
Expand Down Expand Up @@ -687,6 +683,7 @@ def phase_linker_setup(options, state, newargs):
if not settings.ASSERTIONS:
exit_with_error('PTHREADS_PROFILING only works with ASSERTIONS enabled')
options.post_js.append(utils.path_from_root('src/threadprofiler.js'))
settings.REQUIRED_EXPORTS.append('emscripten_main_runtime_thread_id')

options.extern_pre_js = read_js_files(options.extern_pre_js)
options.extern_post_js = read_js_files(options.extern_post_js)
Expand Down
Loading