Use encodeURIComponent in browser_reporting. NFC #23075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandahl
approved these changes
Dec 4, 2024
While working on a separate change I ran into issues where chrome was refusing to fetch a report_result and this fixed the issue.
sbc100
changed the title
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
While working on a separate change I ran into issues where chrome was
refusing to fetch a report_result and this fixed the issue.
It seems that the angle brackets in the backtrace after my PR were the
issue:
Before:
```
exception:fetch is not a function / TypeError: fetch is not a function
at readAsync (https://b2607f8….proxy.googlers.com/a.out.js:284:12)
at getBinaryPromise (https://b2607f8….proxy.googlers.com/a.out.js:774:12)
at instantiateArrayBuffer (https://b2607f8….proxy.googlers.com/a.out.js:786:10)
at instantiateAsync (https://b2607f8….proxy.googlers.com/a.out.js:832:10)
at createWasm (https://b2607f8….proxy.googlers.com/a.out.js:909:3)
at https://b2607f8….proxy.googlers.com/a.out.js:5310:19
```
After:
```
exception:fetch is not a function / TypeError: fetch is not a function
at readAsync (https://b2607f8….proxy.googlers.com/a.out.js:294:12)
at getBinaryPromise (https://b2607f8….proxy.googlers.com/a.out.js:818:12)
at https://b2607f8….proxy.googlers.com/a.out.js:831:5
at new Promise (<anonymous>)
at instantiateArrayBuffer (https://b2607f8….proxy.googlers.com/a.out.js:830:10)
at instantiateAsync (https://b2607f8….proxy.googlers.com/a.out.js:881:10)
at createWasm (https://b2607f8….proxy.googlers.com/a.out.js:958:3)
at https://b2607f8….proxy.googlers.com/a.out.js:5368:19
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a separate change I ran into issues where chrome was refusing to fetch a report_result and this fixed the issue.
It seems that the angle brackets in the backtrace after my PR were the issue:
Before:
After: