From 72aa41bca31f8c82fbf5aacdffb5dca3605c5be6 Mon Sep 17 00:00:00 2001 From: Derek Schuff Date: Fri, 6 Dec 2024 09:59:10 -0800 Subject: [PATCH 1/2] Disable test_fs_enotdir on Windows This seems to be another instance of #8882 where errno values don't match. This could be "fixed" by making the error check a little looser if we care about the behavior of NODERAWFS on Windows. For now just disable to unblock the rollers. --- test/test_core.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_core.py b/test/test_core.py index 2163d969cffc1..232c2dd02eb9c 100644 --- a/test/test_core.py +++ b/test/test_core.py @@ -5781,6 +5781,7 @@ def test_fs_write(self): def test_fs_emptyPath(self): self.do_run_in_out_file_test('fs/test_emptyPath.c') + @no_windows('https://github.com/emscripten-core/emscripten/issues/8882') @also_with_noderawfs def test_fs_enotdir(self): self.do_run_in_out_file_test('fs/test_enotdir.c') From 089998baaeaee1b45b2cab7620d21b88183dff4e Mon Sep 17 00:00:00 2001 From: Derek Schuff Date: Fri, 6 Dec 2024 10:22:13 -0800 Subject: [PATCH 2/2] add @crossplatform --- test/test_core.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_core.py b/test/test_core.py index 232c2dd02eb9c..27580a512d9ae 100644 --- a/test/test_core.py +++ b/test/test_core.py @@ -5782,6 +5782,7 @@ def test_fs_emptyPath(self): self.do_run_in_out_file_test('fs/test_emptyPath.c') @no_windows('https://github.com/emscripten-core/emscripten/issues/8882') + @crossplatform @also_with_noderawfs def test_fs_enotdir(self): self.do_run_in_out_file_test('fs/test_enotdir.c')