From 29247a4ecccdceba1000aef77cf2dc00a30f3906 Mon Sep 17 00:00:00 2001 From: Derek Schuff Date: Fri, 6 Dec 2024 12:57:58 -0800 Subject: [PATCH 1/2] Skip symlink tests on Windows Followup to #23072 --- test/test_core.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/test_core.py b/test/test_core.py index 09aaa129b6ffd..12867309eddf8 100644 --- a/test/test_core.py +++ b/test/test_core.py @@ -5875,6 +5875,7 @@ def test_fs_64bit(self): self.do_runf('fs/test_64bit.c', 'success') @requires_node + @crossplatform @parameterized({ '': ([],), 'nodefs': (['-DNODEFS', '-lnodefs.js'],), @@ -5883,6 +5884,8 @@ def test_fs_64bit(self): def test_fs_symlink_resolution(self, args): nodefs = '-DNODEFS' in args or '-sNODERAWFS' in args if self.get_setting('WASMFS'): + if WINDOWS: + self.skipTest('No symlinks on Windows') if nodefs: self.skipTest('NODEFS in WasmFS') self.set_setting('FORCE_FILESYSTEM') From 6ec5c53da22ef70a0cfc4a9b8a3fba86b02af096 Mon Sep 17 00:00:00 2001 From: Derek Schuff Date: Fri, 6 Dec 2024 14:15:14 -0800 Subject: [PATCH 2/2] fix --- test/test_core.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/test_core.py b/test/test_core.py index 12867309eddf8..9e62f056f3bf9 100644 --- a/test/test_core.py +++ b/test/test_core.py @@ -5883,9 +5883,9 @@ def test_fs_64bit(self): }) def test_fs_symlink_resolution(self, args): nodefs = '-DNODEFS' in args or '-sNODERAWFS' in args + if nodefs and WINDOWS: + self.skipTest('No symlinks on Windows') if self.get_setting('WASMFS'): - if WINDOWS: - self.skipTest('No symlinks on Windows') if nodefs: self.skipTest('NODEFS in WasmFS') self.set_setting('FORCE_FILESYSTEM')