[AUDIO_WORKLET] Fix when compiling with STRICT #23130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
(The build errors look unrelated) |
Random timeouts are causing tests to fail.
Collaborator
|
I guess we can land this now and then ensure that the tests are correctly reporting errors as a followup? |
sbc100
approved these changes
Dec 12, 2024
Collaborator
Author
Yes, I plan to look at the tests soon-ish (after the API change draft). |
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
Fix for emscripten-core#22971. This highlights that the AW tests weren't catching this or other issues in the parameterised tests. Running, for example: ``` test/runner browser.test_audio_worklet_strict ``` Passes, but if compiled with the same settings doesn't run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #22971.
This highlights that the AW tests weren't catching this or other issues in the parameterised tests. Running, for example:
Passes, but if compiled with the same settings doesn't run.