Remove unnecessary functions from jsmath.c. NFC #23143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
|
See emscripten/system/include/emscripten/em_math.h Lines 25 to 36 in 1171ada |
sbc100
force-pushed
the
simplify_jsmath
branch
2 times, most recently
from
e724526 to
f421b08
Compare
sbc100
commented
Dec 12, 2024
| }) | ||
|
|
||
| double nearbyint(double x) { return rint(x); } | ||
| float nearbyintf(float x) { return rintf(x); } |
There was a problem hiding this comment.
These two are already implement in musl in terms of rint and rintf
sbc100
force-pushed
the
simplify_jsmath
branch
from
f421b08 to
1c9b29d
Compare
kripken
approved these changes
Dec 12, 2024
See the comments at the top of `emscripten/js_math.h` for why JS versions of these functions are not needed. As a followup I plan to map `jsmath.c` functions to `em_math.h` functions instead of using EM_JS here. See emscripten-core#19284
sbc100
force-pushed
the
simplify_jsmath
branch
from
1c9b29d to
c35b7e0
Compare
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
See the comments at the top of `emscripten/js_math.h` for why JS versions of these functions are not needed. As a followup I plan to map `jsmath.c` functions to `em_math.h` functions instead of using EM_JS here. See emscripten-core#19284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comments at the top of
emscripten/js_math.hfor why JS versions of these functions are not needed.As a followup I plan to map
jsmath.cfunctions toem_math.hfunctions instead of using EM_JS here.See #19284