Add backspace/tab tests for input elements [NFC] #23285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for #22879
The glfw test passes as is, and when modified for that PR, passes with that PR.
However, the SDL test does not work, even before that PR, related to SDL
checking
!SDL.unicode && !SDL.textInputbefore doingpreventDefault,https://github.com/emscripten-core/emscripten/pull/22879/files#diff-d34003e633a5e6cebdd7d5f53a624b636ea6e36f59c208107fb829f5cefcd107L699
The very first assert fails in SDL.
That suggests to me that perhaps the SDL side of that PR is not actually needed?