Export data addresses from the Wasm module just like other symbols. #25568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
data_symbol_exports
branch
2 times, most recently
from
1808912 to
d72fca6
Compare
kripken
approved these changes
Oct 16, 2025
sbc100
force-pushed
the
data_symbol_exports
branch
3 times, most recently
from
65a7082 to
6c1b746
Compare
This removes the special handling of exported immutable globals which simplifies the code in a few different ways. For programs that export data addresses (this is relatively rare) this means codesize reduction for the generated JS (since it no longer contains the constant values) and the codesize increase for the Wasm binary (since it now contains extra exports). The main reason for this is consistency with dynamic linking (where data exports are always needed) and a reduction in complexity. The following (14) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_minimal_64.json: 2657 => 2671 [+14 bytes / +0.53%] test/codesize/test_codesize_minimal_O0.expected.js updated codesize/test_codesize_minimal_O0.json: 20398 => 20501 [+103 bytes / +0.50%] codesize/test_codesize_minimal_O1.json: 3498 => 3510 [+12 bytes / +0.34%] codesize/test_codesize_minimal_O2.json: 2622 => 2632 [+10 bytes / +0.38%] codesize/test_codesize_minimal_O3.json: 2354 => 2368 [+14 bytes / +0.59%] codesize/test_codesize_minimal_Os.json: 2354 => 2368 [+14 bytes / +0.59%] codesize/test_codesize_minimal_Os_mr.json: 559 => 572 [+13 bytes / +2.33%] codesize/test_codesize_minimal_Oz-ctors.json: 2322 => 2336 [+14 bytes / +0.60%] codesize/test_codesize_minimal_Oz.json: 2354 => 2368 [+14 bytes / +0.59%] codesize/test_codesize_minimal_esm.json: 2489 => 2504 [+15 bytes / +0.60%] codesize/test_codesize_minimal_pthreads.json: 27208 => 27220 [+12 bytes / +0.04%] codesize/test_codesize_minimal_pthreads_memgrowth.json: 27636 => 27648 [+12 bytes / +0.04%] codesize/test_codesize_minimal_wasmfs.json: 2354 => 2368 [+14 bytes / +0.59%] Average change: +0.60% (+0.04% - +2.33%) ```
sbc100
force-pushed
the
data_symbol_exports
branch
from
6c1b746 to
2c3efc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the special handling of exported immutable globals which simplifies the code in a few different ways.
For programs that export data addresses (this is relatively rare) this means codesize reduction for the generated JS (since it no longer contains the constant values) and the codesize increase for the Wasm binary (since it now contains extra exports).
The main reason for this is consistency with dynamic linking (where data exports are always needed) and a reduction in complexity.
The following (14) test expectation files were updated by running the tests with
--rebaseline: