Enable -shared via a new FAKE_DYLIBS setting. NFC
#25826
+100
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Do you mean this "does not" change the default behavior? |
Collaborator
Author
Fixed |
dschuff
reviewed
Nov 19, 2025
Collaborator
Author
|
@hoodmane hopefully this will be good for you guys and simplify building python side modules |
sbc100
force-pushed
the
fake_dylibs
branch
2 times, most recently
from
dea16bc to
bd68dca
Compare
Collaborator
Author
Fixed |
This this change the default behaviour does not change since `FAKE_DYLIBS` defaults to false. However for users who want to try out a more traditional shared library workflow `-sFAKE_DYLIBS=0` can be used enable shared library output with `-shared`. At some point in the future we can consider making this the default. Split out from emscripten-core#25817
Collaborator
Author
|
PTAL, tests are all passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour does not change since
FAKE_DYLIBSdefaults to true.However for users who want to try out a more traditional shared library workflow
-sFAKE_DYLIBS=0can be used enable shared library output with-shared.At some point in the future we can consider making this the default.
Split out from #25817