Skip to content

Disabled test_std_filesystem_{tempdir_}wasmfs_rawfs. NFC #25861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2025
Merged

Disabled test_std_filesystem_{tempdir_}wasmfs_rawfs. NFC #25861

merged 1 commit into from
Nov 24, 2025

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 24, 2025

These tests depend on being able to access arbitrary paths which doesn't currently work with NODERAWFS + WASMFS.

See #18820

@sbc100
Disabled test_std_filesystem_{tempdir_}wasmfs_rawfs. NFC
b6a5264 
These tests depend on being able to access arbitrary paths which
doesn't currently work with NODERAWFS + WASMFS.

See emscripten-core#18820
@sbc100 sbc100 requested a review from dschuff November 24, 2025 21:40
@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 24, 2025

These tests happened to pass on linux + noderawfs + wasmfs in our CI because it happens to work went TMP/TMPDIR happen to point to /tmp (which wasmfs explictly mounts).

dschuff
dschuff approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the win/mac check is ok because NODERAWFS is just always unset on those platforms?

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 24, 2025

removing the win/mac check is ok because NODERAWFS is just always unset on those platforms?

This change only effects NODERAWFS +WASMFS versions of the test.

This change just makes them skip on all OSes because they basically don't work in the general case due to limitations of WASMFS.

@sbc100 sbc100 enabled auto-merge (squash) November 24, 2025 21:57
@sbc100 sbc100 merged commit 797cf32 into emscripten-core:main Nov 24, 2025
34 checks passed
@sbc100 sbc100 deleted the disable_wasmfs_nodefs branch November 24, 2025 22:27
@kleisauke
Copy link
Collaborator

kleisauke commented Nov 25, 2025

For reference, the issue related to absolute path access (when using -sNODERAWFS + -sWASMFS) is being tracked in #24830.

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 25, 2025

Thanks @kleisauke I will update those skipTests with that link

sbc100 added a commit to sbc100/emscripten that referenced this pull request Nov 25, 2025
@sbc100
Add bug links to disabled tests from emscripten-core#25861. NFC
2a4b853
sbc100 added a commit that referenced this pull request Nov 25, 2025
@sbc100
Add bug links to disabled tests from #25861. NFC (#25864)
2f01ef4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dschuff dschuff dschuff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbc100 @kleisauke @dschuff