Provide "executable" in wasm_cc_binary's DefaultInfo. (#998)

PiotrSikora · web-flow · commit 0ea8f8a87070 · 2022-03-09T07:09:39.000-08:00
This is needed to allow custom rules and/or transitions on top of wasm_cc_binary (e.g. to workaround #972). It's debatable whether .wasm is the correct executable target for non-standalone Wasm builds, but we don't have a way to differentiate those in wasm_cc_binary, and considering that this attribute isn't exported now, it shouldn't break anything.
diff --git a/bazel/emscripten_toolchain/wasm_cc_binary.bzl b/bazel/emscripten_toolchain/wasm_cc_binary.bzl
@@ -80,6 +80,7 @@ def _wasm_binary_impl(ctx):
     )
 
     return DefaultInfo(
+        executable = ctx.outputs.wasm,
         files = depset(outputs),
         # This is needed since rules like web_test usually have a data
         # dependency on this target.

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,7 @@ def _wasm_binary_impl(ctx):`
`80`	`80`	`)`
`81`	`81`
`82`	`82`	`return DefaultInfo(`
	`83`	`+ executable = ctx.outputs.wasm,`
`83`	`84`	`files = depset(outputs),`
`84`	`85`	`# This is needed since rules like web_test usually have a data`
`85`	`86`	`# dependency on this target.`