Skip to content

Commit 1e2f1a2

Browse files
authored
Update Node from 18.20.3 LTS to 20.18.0 in precompiled releases. (#1476)
Update Node from 18.20.3 LTS to 20.18.0 in precompiled releases. This does have an effect of retroactively updating Node version also to old releases, but this is expected to be fine.
1 parent 5e398ab commit 1e2f1a2

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ COPY --from=stage_build /emsdk /emsdk
6363
# using `--entrypoint /bin/bash` in CLI).
6464
# This corresponds to the env variables set during: `source ./emsdk_env.sh`
6565
ENV EMSDK=/emsdk \
66-
PATH="/emsdk:/emsdk/upstream/emscripten:/emsdk/node/18.20.3_64bit/bin:${PATH}"
66+
PATH="/emsdk:/emsdk/upstream/emscripten:/emsdk/node/20.18.0_64bit/bin:${PATH}"
6767

6868
# ------------------------------------------------------------------------------
6969
# Create a 'standard` 1000:1000 user

emsdk_manifest.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -392,30 +392,30 @@
392392
{
393393
"version": "releases-%releases-tag%",
394394
"bitness": 64,
395-
"uses": ["node-18.20.3-64bit", "releases-%releases-tag%-64bit"],
395+
"uses": ["node-20.18.0-64bit", "releases-%releases-tag%-64bit"],
396396
"os": "linux",
397397
"custom_install_script": "emscripten_npm_install"
398398
},
399399
{
400400
"version": "releases-%releases-tag%",
401401
"bitness": 64,
402-
"uses": ["node-18.20.3-64bit", "python-3.9.2-64bit", "releases-%releases-tag%-64bit"],
402+
"uses": ["node-20.18.0-64bit", "python-3.9.2-64bit", "releases-%releases-tag%-64bit"],
403403
"os": "macos",
404404
"arch": "x86_64",
405405
"custom_install_script": "emscripten_npm_install"
406406
},
407407
{
408408
"version": "releases-%releases-tag%",
409409
"bitness": 64,
410-
"uses": ["node-18.20.3-64bit", "python-3.9.2-64bit", "releases-%releases-tag%-64bit"],
410+
"uses": ["node-20.18.0-64bit", "python-3.9.2-64bit", "releases-%releases-tag%-64bit"],
411411
"os": "macos",
412412
"arch": "arm64",
413413
"custom_install_script": "emscripten_npm_install"
414414
},
415415
{
416416
"version": "releases-%releases-tag%",
417417
"bitness": 64,
418-
"uses": ["node-18.20.3-64bit", "python-3.9.2-nuget-64bit", "java-8.152-64bit", "releases-%releases-tag%-64bit"],
418+
"uses": ["node-20.18.0-64bit", "python-3.9.2-nuget-64bit", "java-8.152-64bit", "releases-%releases-tag%-64bit"],
419419
"os": "win",
420420
"custom_install_script": "emscripten_npm_install"
421421
}

test/test.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ def test_redownload(self):
176176

177177
# Test the normal tools like node don't re-download on re-install
178178
print('another install must re-download')
179-
checked_call_with_output(emsdk + ' uninstall node-18.20.3-64bit')
180-
checked_call_with_output(emsdk + ' install node-18.20.3-64bit', expected='Downloading:', unexpected='already installed')
181-
checked_call_with_output(emsdk + ' install node-18.20.3-64bit', unexpected='Downloading:', expected='already installed')
179+
checked_call_with_output(emsdk + ' uninstall node-20.18.0-64bit')
180+
checked_call_with_output(emsdk + ' install node-20.18.0-64bit', expected='Downloading:', unexpected='already installed')
181+
checked_call_with_output(emsdk + ' install node-20.18.0-64bit', unexpected='Downloading:', expected='already installed')
182182

183183
def test_tot_upstream(self):
184184
print('test update-tags')

0 commit comments

Comments
 (0)