Skip to content

Commit 2b10b1b

Browse files
authored
Use default python in PATH for circleci windows bot. NFC (#1609)
`C:\Python312\python.exe` is already in the path by default. We no longer need to set this special path or environment variable. In fact this code was doing nothing since it was adding the end of the PATH so the system python was already coming first.
1 parent 44f11ea commit 2b10b1b

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

.circleci/config.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -138,22 +138,17 @@ jobs:
138138
name: win/server-2019
139139
shell: bash.exe
140140
environment:
141-
# We need python installed before we can test anytyhing.
142-
# There seems to be undocument copy of python installed here. Hopefully
143-
# if this disappears there will be another way of getting a re-installed
144-
# version.
145-
PYTHON_BIN: "C:\\Python27amd64"
146141
PYTHONUNBUFFERED: "1"
147142
EMSDK_NOTTY: "1"
148143
steps:
149144
- checkout
150-
- run:
151-
name: Add python to bash path
152-
command: echo "export PATH=\"$PATH:/c/python27amd64/\"" >> $BASH_ENV
145+
- run: where python
146+
153147
- run:
154148
name: Install latest
155149
shell: cmd.exe
156150
command: test\test.bat
151+
157152
- run:
158153
name: test.py
159154
command: |

test/test.bat

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
:: equivalent of test.sh as windows bat file
2-
set PATH=%PATH%;%PYTHON_BIN%
32
CALL emsdk install latest
43
CALL emsdk activate latest
54
CALL emsdk_env.bat

0 commit comments

Comments
 (0)