Skip to content

Commit 476dc4e

Browse files
authored
Add missing comma from #1429 (#1433)
Turns out this is what was causing the OOM when building binaryen since we were clobbering the EMSDK_NUM_CORES environment variable by mistake. See #1429
1 parent fad40cf commit 476dc4e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

emsdk.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2632,7 +2632,7 @@ def construct_env_with_vars(env_vars_to_add):
26322632
# of the SDK but we want to remove that from the current environment
26332633
# if no such tool is active.
26342634
# Ignore certain keys that are inputs to emsdk itself.
2635-
ignore_keys = set(['EMSDK_POWERSHELL', 'EMSDK_CSH', 'EMSDK_CMD', 'EMSDK_BASH', 'EMSDK_FISH'
2635+
ignore_keys = set(['EMSDK_POWERSHELL', 'EMSDK_CSH', 'EMSDK_CMD', 'EMSDK_BASH', 'EMSDK_FISH',
26362636
'EMSDK_NUM_CORES', 'EMSDK_NOTTY', 'EMSDK_KEEP_DOWNLOADS'])
26372637
env_keys_to_add = set(pair[0] for pair in env_vars_to_add)
26382638
for key in os.environ:

0 commit comments

Comments
 (0)