Skip to content

Commit 61c35ab

Browse files
authored
Don't advertise "per_object_debug_info" feature in Bazel. (#969)
It breaks @emsdk in workspaces that have this feature enabled. The following error appears when using the latest commit: cc_toolchain '@emsdk//emscripten_toolchain:everything' with identifier 'emscripten-wasm' doesn't define a tool path for 'dwp' The following error appears after adding `emdwp` tool and scripts: output '*.dwo' was not created Signed-off-by: Piotr Sikora <[email protected]>
1 parent 23b3e18 commit 61c35ab

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

bazel/emscripten_toolchain/crosstool.bzl

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -298,10 +298,6 @@ def _impl(ctx):
298298
# Blaze also tests if this feature is supported, before setting the "pic" build-variable.
299299
feature(name = "pic"),
300300

301-
# Blaze requests this feature if fission is requested
302-
# Blaze also tests if it's supported to see if we support fission.
303-
feature(name = "per_object_debug_info"),
304-
305301
# Blaze requests this feature by default.
306302
# Blaze also tests if this feature is supported before setting preprocessor_defines
307303
# (...but why?)

0 commit comments

Comments
 (0)