Skip to content

Commit b0fda89

Browse files
authored
Revert "Add 'latest-fastcomp' sdk (#200)" (#202)
This reverts commit b4de632. This caused the ec2 mozilla builders to fail due to bundling lkgr.json. Reverting til we figure it out.
1 parent b4de632 commit b0fda89

File tree

3 files changed

+4
-35
lines changed

3 files changed

+4
-35
lines changed

Dockerfile

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,13 @@ RUN cd /root/ \
99
&& echo "int main() {}" > hello_world.cpp \
1010
&& apt-get update \
1111
&& apt-get install -y python cmake build-essential openjdk-9-jre-headless \
12-
&& /root/emsdk/emsdk update-tags \
13-
&& echo "test latest" \
1412
&& /root/emsdk/emsdk install latest \
1513
&& /root/emsdk/emsdk activate latest \
1614
&& source /root/emsdk/emsdk_env.sh --build=Release \
1715
&& emcc hello_world.cpp \
18-
&& echo "test upstream (waterfall)" \
16+
&& /root/emsdk/emsdk update-tags \
1917
&& /root/emsdk/emsdk install latest-upstream \
2018
&& /root/emsdk/emsdk activate latest-upstream \
2119
&& source /root/emsdk/emsdk_env.sh --build=Release \
22-
&& emcc hello_world.cpp -s WASM_OBJECT_FILES=1 \
23-
&& echo "test fastcomp (waterfall)" \
24-
&& /root/emsdk/emsdk install latest-fastcomp \
25-
&& /root/emsdk/emsdk activate latest-fastcomp \
26-
&& source /root/emsdk/emsdk_env.sh --build=Release \
27-
&& emcc hello_world.cpp \
28-
&& emcc hello_world.cpp -s WASM=0
20+
&& emcc hello_world.cpp -s WASM_OBJECT_FILES=1
2921

emsdk

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,18 +1527,12 @@ def find_latest_nightly_sdk():
15271527
else:
15281528
return find_latest_nightly_32bit_sdk()
15291529

1530-
def find_latest_waterfall_sdk(which):
1530+
def find_latest_upstream_sdk():
15311531
waterfall_lkgr = load_waterfall_lkgr()
15321532
if not waterfall_lkgr:
15331533
print('Failed to find an upstream lkgr')
15341534
sys.exit(1)
1535-
return 'sdk-%s-%s-64bit' % (which, waterfall_lkgr[0])
1536-
1537-
def find_latest_upstream_sdk():
1538-
return find_latest_waterfall_sdk('upstream')
1539-
1540-
def find_latest_fastcomp_sdk():
1541-
return find_latest_waterfall_sdk('fastcomp')
1535+
return 'sdk-upstream-%s-64bit' % waterfall_lkgr[0]
15421536

15431537
# Finds the best-matching python tool for use.
15441538
def find_used_python():
@@ -2231,8 +2225,6 @@ def main():
22312225
sys.argv[i] = str(find_latest_nightly_64bit_sdk())
22322226
elif sys.argv[i] == 'latest-upstream' or sys.argv[i] == 'latest-clang-upstream':
22332227
sys.argv[i] = str(find_latest_upstream_sdk())
2234-
elif sys.argv[i] == 'latest-fastcomp':
2235-
sys.argv[i] = str(find_latest_fastcomp_sdk())
22362228

22372229
if cmd == 'list':
22382230
print('')

emsdk_manifest.json

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -199,15 +199,6 @@
199199
"activated_path": "%installation_dir%/emscripten",
200200
"activated_cfg": "LLVM_ROOT='%installation_dir%/bin';BINARYEN_ROOT='%installation_dir%'"
201201
},
202-
{
203-
"id": "waterfall",
204-
"version": "fastcomp-%waterfall-lkgr%",
205-
"bitness": 64,
206-
"linux_url": "https://storage.googleapis.com/wasm-llvm/builds/linux/%waterfall-lkgr%/wasm-binaries.tbz2",
207-
"install_path": "fastcomp/%waterfall-lkgr%",
208-
"activated_path": "%installation_dir%/emscripten",
209-
"activated_cfg": "LLVM_ROOT='%installation_dir%/fastcomp/bin';BINARYEN_ROOT='%installation_dir%'"
210-
},
211202
{
212203
"id": "clang",
213204
"version": "e1.13.0",
@@ -1558,12 +1549,6 @@
15581549
"uses": ["waterfall-upstream-%waterfall-lkgr%-64bit", "node-8.9.1-64bit"],
15591550
"os": "linux"
15601551
},
1561-
{
1562-
"version": "fastcomp-%waterfall-lkgr%",
1563-
"bitness": 64,
1564-
"uses": ["waterfall-fastcomp-%waterfall-lkgr%-64bit", "node-8.9.1-64bit"],
1565-
"os": "linux"
1566-
},
15671552
{
15681553
"version": "%precompiled_tag32%",
15691554
"bitness": 32,

0 commit comments

Comments
 (0)