Skip to content

Fix support fish shell in emsdk.py #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix support fish shell in emsdk.py #1239

wants to merge 1 commit into from

Conversation

shao4598
Copy link

Shell: Fish
OS: macOS

$ set -x EMSDK_QUIET 1
$ source ./emsdk_env.fish

fish: Unknown command: unset

sbc100
sbc100 approved these changes Jun 23, 2023
View reviewed changes
emsdk.py
@@ -114,15 +114,16 @@ def exit_with_error(msg):
UNIX = (MACOS or LINUX)


# Pick which shell of 4 shells to use
# Pick which shell of 5 shells to use
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just # Pick which shell to use?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add some basic CI testing for other shells?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 I agree with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shao4598 @sbc100