Fix

Author: martinRenou

empack/pack.py

@@ -231,11 +231,11 @@ def add_tarfile_to_env_meta(env_meta_filename, tarfile):
         env_meta["mounts"] = []
 
     # check that the mount point is not already in the list
-    for pkg in env_meta["mounts"]:
-        if pkg["filename"] == tarfile_name:
+    for mount_point in env_meta["mounts"]:
+        if mount_point["filename"] == tarfile_name:
             msg = f"mount point with filename '{tarfile_name}' already in env meta file"
             raise RuntimeError(msg)
-        if pkg["name"] == mount_point_item["name"]:
+        if mount_point["name"] == mount_point_item["name"]:
             msg = f"mount point with name '{mount_point_item['name']}' already in env meta file"
             raise RuntimeError(msg)
 

tests/test_cli.py

@@ -94,9 +94,9 @@ def test_pack_env(self, tmp_path, use_cache):
         env_meta_dict = dict()
 
         for pkg in mount_points:
-            env_meta_dict[pkg["filename"]] = pkg
+            env_meta_dict[pkg["name"]] = pkg
         for pkg in packages:
-            env_meta_dict[pkg["filename"]] = pkg
+            env_meta_dict[pkg["name"]] = pkg
 
         assert "packaged_dir.tar.gz" in env_meta_dict
         assert "numpy" in env_meta_dict