adding github actions ci workflow (#1)

* adding ci

Author: DerThorsten

.github/workflows/main.yaml

@@ -0,0 +1,100 @@
+name: CI
+
+on:
+  workflow_dispatch:
+  push:
+  pull_request:
+
+
+defaults:
+  run:
+    shell: bash -l {0}
+
+
+jobs:
+
+  test_with_conda:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        emsdk_ver: ["3.1.2"]
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Get number of CPU cores
+        uses: SimenB/github-actions-cpu-cores@v1
+
+      - name: Install mamba
+        uses: mamba-org/provision-with-micromamba@main
+        with:
+          environment-file: dev-env.yml
+          environment-name: dev-env
+          micromamba-version: "0.22.0"
+
+      - name: Install Playwright
+        run: |
+          playwright install
+
+      - name: Setup emsdk
+        run: |
+          micromamba activate dev-env
+          emsdk install ${{matrix.emsdk_ver}}
+
+      - name: Install pyjs-code-runner
+        run: |
+          micromamba activate dev-env
+          python -m pip install . --no-deps
+        
+      - name: Run Tests 
+        run: |
+          micromamba activate dev-env
+          emsdk activate ${{matrix.emsdk_ver}}
+          source $CONDA_EMSDK_DIR/emsdk_env.sh
+
+          pytest -s
+
+
+  test_with_pip:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        emsdk_ver: ["3.1.2"]
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Get number of CPU cores
+        uses: SimenB/github-actions-cpu-cores@v1
+
+      - name: Install mamba
+        uses: mamba-org/provision-with-micromamba@main
+        with:
+          environment-file: dev-env-pip.yml
+          environment-name: dev-env
+          micromamba-version: "0.22.0"
+
+      
+      - name: Install pyjs-code-runner
+        run: |
+          micromamba activate dev-env
+          emsdk install ${{matrix.emsdk_ver}}
+
+          python -m pip install . 
+          playwright install
+        
+      - name: Run Tests 
+        run: |
+          micromamba activate dev-env
+          emsdk activate ${{matrix.emsdk_ver}}
+          source $CONDA_EMSDK_DIR/emsdk_env.sh
+
+          pytest -s
+
+ 

MANIFEST.in

@@ -0,0 +1,5 @@
+include pyjs_code_runner/html/browser_main.html
+include pyjs_code_runner/html/browser_worker.html
+include pyjs_code_runner/js/utils.js
+include pyjs_code_runner/js/worker.js
+include pyjs_code_runner/backend/node/node_main.js

dev-env-pip.yml

@@ -0,0 +1,8 @@
+name: ci-env
+channels:
+  - conda-forge
+dependencies:
+  - python
+  - pip
+  - emsdk
+  - pytest

dev-env.yml

@@ -0,0 +1,13 @@
+name: ci-env
+channels:
+  - conda-forge
+dependencies:
+  - python
+  - pip
+  - pytest
+  - typer
+  - appdirs
+  - empack >=2.0.0
+  - microsoft::playwright
+  - emsdk
+  - rich

pyjs_code_runner/backend/backend.py

@@ -36,18 +36,24 @@ def ensure_playwright_imports():
                 * conda:
 
                     conda install -c microsoft playwright
+                    playwright install
 
                 * mamba:
 
                     mamba install -c microsoft playwright
+                    playwright install
 
                 * micromamba:
 
                     micromamb install -c microsoft playwright
+                    playwright install
 
                 * pip:
 
                     python -m pip install playwright
+                    playwright install
+
+
 
         """
         raise ModuleNotFoundError(textwrap.dedent(msg))

pyjs_code_runner/backend/browser_main/browser_main.py

@@ -40,6 +40,8 @@ def run(self):
 
             page_url = f"{url}/{browser_main_html}"
             ret = asyncio.run(self.playwright_run_in_main_thread(page_url=page_url))
+            if ret != 0:
+                raise RuntimeError("return_code != 0")
 
     async def playwright_run_in_main_thread(self, page_url):
         async with async_playwright() as p:

pyjs_code_runner/backend/browser_main/server.py

@@ -30,6 +30,8 @@ def log_message(self, fmt, *args):
 @contextmanager
 def server_context(work_dir, port):
     thread, server = start_server(work_dir=work_dir, port=port)
-    yield server, f"http://127.0.0.1:{port}"
-    server.shutdown()
-    thread.join()
+    try:
+        yield server, f"http://127.0.0.1:{port}"
+    finally:
+        server.shutdown()
+        thread.join()

pyjs_code_runner/backend/browser_worker/browser_worker.py

@@ -2,7 +2,7 @@
 import asyncio
 from ..backend_base import BackendBase
 from ...constants import JS_DIR, HTML_DIR
-from .server import server_context, find_free_port
+from ..browser_main.server import server_context, find_free_port
 from playwright.async_api import async_playwright
 from pathlib import Path
 import shutil
@@ -43,6 +43,8 @@ def run(self):
 
             page_url = f"{url}/{browser_worker_html}"
             ret = asyncio.run(self.playwright_run_in_worker_thread(page_url=page_url))
+            if ret != 0:
+                raise RuntimeError("return_code != 0")
 
     async def playwright_run_in_worker_thread(self, page_url):
         async with async_playwright() as p:

pyjs_code_runner/backend/browser_worker/server.py

@@ -2,6 +2,7 @@
 from pathlib import Path
 import os
 import shutil
+import json
 import sys
 import shutil
 from ..backend_base import BackendBase
@@ -53,22 +54,33 @@ def __init__(self, host_work_dir, work_dir, script, async_main, node_binary):
                 node_binary = shutil_node_binary
         self.node_binary = node_binary
 
+    def supports_flag_no_experimental_fetch(self):
+        probe_cmd = [self.node_binary, "--no-experimental-fetch", "--version"]
+        ret_code = subprocess.call(
+            probe_cmd, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL
+        )
+        return ret_code == 0
+
     def run(self):
         main_name = "node_main.js"
         main = Path(THIS_DIR) / main_name
         shutil.copyfile(main, self.host_work_dir / main_name)
 
-        cmd = [
-            self.node_binary,
-            "--no-experimental-fetch",
-            main_name,
-            self.work_dir,
-            self.script,
-            str(int(self.async_main)),
-        ]
+        cmd = [self.node_binary]
+        if self.supports_flag_no_experimental_fetch():
+            cmd.append("--no-experimental-fetch")
+
+        cmd.extend(
+            [
+                main_name,
+                self.work_dir,
+                self.script,
+                str(int(self.async_main)),
+                self.host_work_dir,
+            ]
+        )
 
         process = subprocess.Popen(cmd, stdout=subprocess.PIPE)
-
         # Poll process.stdout to show stdout live
         while True:
             output = process.stdout.readline()
@@ -77,6 +89,16 @@ def run(self):
             if output:
                 print(output.decode().strip())
         rc = process.poll()
-        # print("RC", rc)
         if process.returncode != 0:
-            sys.exit(process.returncode)
+            raise RuntimeError(
+                f"node return with returncode: {process.returncode} rc {rc}"
+            )
+
+        result_path = self.host_work_dir / "_node_result.json"
+        if result_path.exists():
+            with open(result_path, "r") as f:
+                results = json.load(f)
+            if results["return_code"] != 0:
+                raise RuntimeError(results["error"])
+        else:
+            raise RuntimeError("internal error in pyjs-code-runner")