optional playwright dependency (for conda)

Author: DerThorsten

pyjs_code_runner/backend/backend.py

@@ -1,8 +1,5 @@
 from enum import Enum
-
-from .node.node import NodeBackend
-from .browser_main.browser_main import BrowserMainBackend
-from .browser_worker.browser_worker import BrowserWorkerBackend
+import textwrap
 
 
 class BackendFamilyType(str, Enum):
@@ -23,10 +20,53 @@ def get_backend_type_family(backend):
         return BackendFamilyType.browser
 
 
+def ensure_playwright_imports():
+    try:
+        import playwright
+    except ModuleNotFoundError as e:
+        msg = """\n
+            pyks-code-runner error: 
+
+                * Cannot import playwright!
+
+            to use the browser-{worker/main} backends
+            playwright needs to be installed.
+
+            Install playwight with:
+
+                * conda:
+
+                    conda install -c microsoft playwright
+
+                * mamba:
+
+                    mamba install -c microsoft playwright
+
+                * micromamba:
+
+                    micromamb install -c microsoft playwright
+
+                * pip:
+
+                    python -m pip install playwright
+
+        """
+        raise ModuleNotFoundError(textwrap.dedent(msg))
+
+
 def get_backend_cls(backend_type):
     if backend_type == BackendType.node:
+        from .node.node import NodeBackend
+
         return NodeBackend
+
     elif backend_type == BackendType.browser_main:
+        ensure_playwright_imports()
+        from .browser_main.browser_main import BrowserMainBackend
+
         return BrowserMainBackend
     elif backend_type == BackendType.browser_worker:
+        ensure_playwright_imports()
+        from .browser_worker.browser_worker import BrowserWorkerBackend
+
         return BrowserWorkerBackend

pyjs_code_runner/backend/browser_main/browser_main.py

@@ -28,14 +28,6 @@ def __init__(
         self.slow_mo = slow_mo
 
     def run(self):
-        print(
-            "run in browser-main",
-            self.script,
-            "port",
-            self.port,
-            "headless",
-            self.headless,
-        )
 
         browser_main_html = "browser_main.html"
         main = HTML_DIR / browser_main_html

pyjs_code_runner/backend/node/node.py

@@ -5,6 +5,7 @@
 import sys
 
 from ..backend_base import BackendBase
+from subprocess import Popen, PIPE, STDOUT
 
 THIS_DIR = os.path.dirname(os.path.realpath(__file__))
 
@@ -21,8 +22,6 @@ def __init__(self, host_work_dir, work_dir, script, async_main, node_exe):
         self.node_exe = node_exe
 
     def run(self):
-        print("run in node", self.script, self.node_exe, "CWD", os.getcwd())
-
         main_name = "node_main.js"
         main = Path(THIS_DIR) / main_name
         shutil.copyfile(main, self.host_work_dir / main_name)
@@ -36,6 +35,26 @@ def run(self):
             str(int(self.async_main)),
         ]
 
-        returncode = subprocess.run(cmd, cwd=os.getcwd()).returncode
-        if returncode != 0:
-            sys.exit(returncode)
+        if False:
+            ret = subprocess.run(cmd, cwd=os.getcwd(), stdout=PIPE)
+            returncode = ret.returncode
+            output = ret.stdout.decode()
+            print(output)
+            if returncode != 0:
+                sys.exit(returncode)
+
+        else:
+            print("START")
+            process = subprocess.Popen(cmd, stdout=subprocess.PIPE)
+
+            # Poll process.stdout to show stdout live
+            while True:
+                output = process.stdout.readline()
+                if process.poll() is not None:
+                    break
+                if output:
+                    print(output.decode().strip())
+            rc = process.poll()
+            # print("RC", rc)
+            if process.returncode != 0:
+                sys.exit(process.returncode)

pyjs_code_runner/backend/node/node_main.js

@@ -27,7 +27,7 @@ async_main = parseInt(process.argv[4]);
         }
         catch(e){
             console.error("error while evaluating main file:",e)
-            return 1;
+            process.exit(1);
         }
         if(async_main)
         {

pyjs_code_runner/js/utils.js

@@ -1,4 +1,3 @@
-console.log("THE UTILS")
 async function make_pyjs(print, error) {
     var pyjs = await createModule({print:print,error:print})
     var EmscriptenForgeModule = pyjs

pyjs_code_runner/js/worker.js

@@ -1,2 +1 @@
-console.log("in woker.js");
 importScripts('./pyjs_runtime_browser.js')

pyjs_code_runner/run.py

@@ -108,6 +108,7 @@ def pack_env(conda_env, backend_type, pkg_file_filter, cache_dir, outdir):
                 outname=outname,
                 export_name=export_name,
                 pkg_file_filter=pkg_file_filter,
+                silent=True,
             )
 
     # copy from cache to work dir