Skip to content

Commit a6c0e29

Browse files
committed
fix: formatting, static types and timedelta in test for mock elapsed
1 parent 1b4495c commit a6c0e29

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

httpx/_transports/mock.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,11 @@ async def handle_async_request(
4949
self._apply_elapsed(response)
5050
return response
5151

52-
def _apply_elapsed(self, response):
52+
def _apply_elapsed(self, response: Response) -> None:
5353
# If the handler already set `response._elapsed`, it is preserved.
5454
# If a delay was provided to MockTransport, `.elapsed` is set to that duration.
5555
# If no delay is provided, `.elapsed` is explicitly set to None.
5656
if hasattr(response, "_elapsed"):
5757
return
5858

59-
if self.delay is not None:
60-
if isinstance(self.delay, timedelta):
61-
response._elapsed = self.delay
62-
else:
63-
response._elapsed = timedelta(seconds=self.delay)
64-
else:
65-
response._elapsed = None
59+
response._elapsed = self.delay

tests/client/test_client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -468,7 +468,7 @@ def handler(request):
468468
r.elapsed = timedelta(seconds=1)
469469
return r
470470

471-
transport = httpx.MockTransport(handler, delay=0.5)
471+
transport = httpx.MockTransport(handler, delay=timedelta(seconds=0.5))
472472
client = httpx.Client(transport=transport)
473473

474474
response = client.get("https://example.com")
@@ -480,7 +480,7 @@ def test_mocktransport_sets_elapsed_to_delay():
480480
def handler(request):
481481
return httpx.Response(200)
482482

483-
transport = httpx.MockTransport(handler, delay=0.5)
483+
transport = httpx.MockTransport(handler, delay=timedelta(seconds=0.5))
484484
client = httpx.Client(transport=transport)
485485

486486
response = client.get("https://example.com")

0 commit comments

Comments
 (0)