dynamically get pk column

Micheal Gendy · Micheal Gendy · commit 592ebba6ee34 · 2022-02-02T16:15:55.000+02:00
diff --git a/orm/models.py b/orm/models.py
@@ -489,7 +489,9 @@ async def bulk_update(
         ]
         expr = (
             self.table.update()
-            .where(self.table.c.id == sqlalchemy.bindparam(self.pkname))
+            .where(
+                getattr(self.table.c, self.pkname) == sqlalchemy.bindparam(self.pkname)
+            )
             .values(
                 {
                     field: sqlalchemy.bindparam(field)
@@ -498,7 +500,7 @@ async def bulk_update(
                 }
             )
         )
-        pk_list = [{self.pkname: obj.pk} for obj in objs]
+        pk_list = [{self.pkname: getattr(obj, self.pkname)} for obj in objs]
         joined_list = [{**pk, **value} for pk, value in zip(pk_list, new_objs)]
         await self.database.execute_many(str(expr), joined_list)
 

Original file line number	Diff line number	Diff line change
`@@ -489,7 +489,9 @@ async def bulk_update(`
`489`	`489`	`]`
`490`	`490`	`expr = (`
`491`	`491`	`self.table.update()`
`492`		`- .where(self.table.c.id == sqlalchemy.bindparam(self.pkname))`
	`492`	`+ .where(`
	`493`	`+ getattr(self.table.c, self.pkname) == sqlalchemy.bindparam(self.pkname)`
	`494`	`+ )`
`493`	`495`	`.values(`
`494`	`496`	`{`
`495`	`497`	`field: sqlalchemy.bindparam(field)`
`@@ -498,7 +500,7 @@ async def bulk_update(`
`498`	`500`	`}`
`499`	`501`	`)`
`500`	`502`	`)`
`501`		`- pk_list = [{self.pkname: obj.pk} for obj in objs]`
	`503`	`+ pk_list = [{self.pkname: getattr(obj, self.pkname)} for obj in objs]`
`502`	`504`	`joined_list = [{pk, value} for pk, value in zip(pk_list, new_objs)]`
`503`	`505`	`await self.database.execute_many(str(expr), joined_list)`
`504`	`506`