Skip to content

Commit 361d79c

Browse files
committed
one less clone
1 parent cf66858 commit 361d79c

File tree

1 file changed

+4
-5
lines changed
  • runtimes/core/src/metrics/exporter

1 file changed

+4
-5
lines changed

runtimes/core/src/metrics/exporter/gcp.rs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,6 @@ impl Gcp {
9999
let ts_end_time: google_cloud_wkt::Timestamp = end_time.try_into().unwrap_or_default();
100100

101101
let mut data: Vec<TimeSeries> = Vec::with_capacity(collected.len());
102-
let container_labels = self.container_meta.labels();
103-
let container_labels_len = container_labels.len();
104102

105103
for metric in collected {
106104
let cloud_metric_name = match self.metric_names.get(metric.key.name()) {
@@ -114,10 +112,11 @@ impl Gcp {
114112
}
115113
};
116114

117-
// Pre-allocate exact capacity for labels
118-
let mut labels: HashMap<String, String> =
115+
let container_labels = self.container_meta.labels();
116+
let container_labels_len = container_labels.len();
117+
let mut labels =
119118
HashMap::with_capacity(container_labels_len + metric.key.labels().len());
120-
labels.extend(container_labels.clone());
119+
labels.extend(container_labels);
121120
labels.extend(
122121
metric
123122
.key

0 commit comments

Comments
 (0)