Skip to content

Commit 3e75caa

Browse files
authored
tracer: Add err log when parsing invalid trace header (#1851)
1 parent ced516a commit 3e75caa

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

pkg/traceparser/parser.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,20 @@ func ParseEvent(buf *bufio.Reader, ta trace2.TimeAnchor, version trace2.Version)
2525
return nil, err
2626
}
2727

28+
typ := trace2.EventType(tp.Byte())
29+
if err := tp.Err(); err != nil {
30+
return nil, err
31+
}
2832
h := header{
29-
Type: trace2.EventType(tp.Byte()),
33+
Type: typ,
3034
EventID: trace2.EventID(tp.Uint64()),
3135
Nanotime: tp.Nanotime(),
3236
TraceID: tp.traceID(),
3337
SpanID: tp.Uint64(),
3438
Len: tp.Uint32(),
3539
}
3640
if err := tp.Err(); err != nil {
41+
log.Error().Err(err).Any("header", h).Msgf("failed to parse event header")
3742
return nil, err
3843
}
3944

0 commit comments

Comments
 (0)