Skip to content

Commit f5d4a3c

Browse files
shimonenatoreandre
authored andcommitted
Fix ability to pass arguments to vitest when using pnpm
Removed unnecessary '--' argument from command. Unlike `npm`, `pnpm` passes `--` through down to vitest: *NPM behavior:* ```bash $ npm run test -- service/service.test.ts > [email protected] test > vitest run service/service.test.ts ``` *PNPM behavior:* ```bash pnpm test -- service/service.test.ts > [email protected] test > vitest run -- service/service.test.ts ``` *Current Encore with PNPM behavior:* ```bash encore test -- service/service.test.ts > [email protected] test > vitest run -- -- service/service.test.ts ``` ```bash encore test service/service.test.ts > [email protected] test > vitest run -- service/service.test.ts ``` *Encore with PNPM behavior with new changes:* ```bash encore test service/service.test.ts > [email protected] test > vitest run service/service.test.ts ```
1 parent c577689 commit f5d4a3c

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

tsparser/src/builder/package_mgmt.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -360,9 +360,6 @@ impl PackageManager for PnpmPackageManager {
360360
"pnpm".to_string(),
361361
"run".to_string(),
362362
"test".to_string(),
363-
// Specify '--' so that additional arguments added from the test runner
364-
// aren't interpreted by npm.
365-
"--".to_string(),
366363
],
367364
env: vec![],
368365
prioritized_files: vec![],

0 commit comments

Comments
 (0)