Clippy

Author: stravant

objdiff-core/src/diff/display.rs

@@ -189,7 +189,7 @@ pub fn display_row(
     let mut arg_idx = 0;
     let mut displayed_relocation = false;
     let analysis_result = if diff_config.show_data_flow {
-        obj.get_flow_analysis_result(&resolved.symbol)
+        obj.get_flow_analysis_result(resolved.symbol)
     } else {
         None
     };
@@ -217,7 +217,7 @@ pub fn display_row(
             }
             let data_flow_value =
             analysis_result.and_then(|result|
-                result.as_ref().get_argument_value_at_address(
+                result.get_argument_value_at_address(
                     ins_ref.address, (arg_idx - 1) as u8));
             match (arg, data_flow_value, resolved.ins_ref.branch_dest) {
                 // If we have a flow analysis result, always use that over anything else.

objdiff-core/src/obj/mod.rs

@@ -331,9 +331,9 @@ impl Object {
     pub fn get_flow_analysis_result(
         &self,
         symbol: &Symbol,
-    ) -> Option<&Box<dyn FlowAnalysisResult>> {
+    ) -> Option<&dyn FlowAnalysisResult> {
         let key = symbol.section.unwrap_or_default() as u64 + symbol.address;
-        self.flow_analysis_results.get(&key)
+        self.flow_analysis_results.get(&key).map(|result| result.as_ref())
     }
 
     pub fn add_flow_analysis_result(