Skip to content

Commit e7e1ec0

Browse files
committed
fmt
1 parent 868c3ab commit e7e1ec0

File tree

5 files changed

+32
-16
lines changed

5 files changed

+32
-16
lines changed

objdiff-cli/src/cmd/report.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@ use anyhow::{Context, Result, bail};
44
use argp::FromArgs;
55
use objdiff_core::{
66
bindings::report::{
7-
ChangeItem, ChangeItemInfo, ChangeUnit, Changes, ChangesInput, Measures, Report, ReportCategory, ReportItem, ReportItemMetadata, ReportUnit, ReportUnitMetadata, REPORT_VERSION
7+
ChangeItem, ChangeItemInfo, ChangeUnit, Changes, ChangesInput, Measures, REPORT_VERSION,
8+
Report, ReportCategory, ReportItem, ReportItemMetadata, ReportUnit, ReportUnitMetadata,
89
},
910
config::path::platform_path,
10-
diff, obj::{self, DiffSide, SectionKind, SymbolFlag},
11+
diff,
12+
obj::{self, DiffSide, SectionKind, SymbolFlag},
1113
};
1214
use prost::Message;
1315
use rayon::iter::{IntoParallelRefIterator, ParallelIterator};
@@ -175,14 +177,16 @@ fn report_object(
175177
.target_path
176178
.as_ref()
177179
.map(|p| {
178-
obj::read::read(p.as_ref(), diff_config, DiffSide::Target).with_context(|| format!("Failed to open {p}"))
180+
obj::read::read(p.as_ref(), diff_config, DiffSide::Target)
181+
.with_context(|| format!("Failed to open {p}"))
179182
})
180183
.transpose()?;
181184
let base = object
182185
.base_path
183186
.as_ref()
184187
.map(|p| {
185-
obj::read::read(p.as_ref(), diff_config, DiffSide::Base).with_context(|| format!("Failed to open {p}"))
188+
obj::read::read(p.as_ref(), diff_config, DiffSide::Base)
189+
.with_context(|| format!("Failed to open {p}"))
186190
})
187191
.transpose()?;
188192
let result =

objdiff-core/src/arch/mips.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,10 @@ use rabbitizer::{
1212

1313
use crate::{
1414
arch::{Arch, RelocationOverride, RelocationOverrideTarget},
15-
diff::{display::InstructionPart, DiffObjConfig, MipsAbi, MipsInstrCategory},
15+
diff::{DiffObjConfig, MipsAbi, MipsInstrCategory, display::InstructionPart},
1616
obj::{
17-
DiffSide, InstructionArg, InstructionArgValue, InstructionRef, Relocation, RelocationFlags, ResolvedInstructionRef, ResolvedRelocation, Section, Symbol, SymbolFlag, SymbolFlagSet
17+
DiffSide, InstructionArg, InstructionArgValue, InstructionRef, Relocation, RelocationFlags,
18+
ResolvedInstructionRef, ResolvedRelocation, Section, Symbol, SymbolFlag, SymbolFlagSet,
1819
},
1920
};
2021

@@ -124,7 +125,9 @@ impl ArchMips {
124125
let Ok(name) = obj_symbol.name() else { continue };
125126
if let Some(prefix) = name.strip_suffix(".NON_MATCHING") {
126127
ignored_symbols.insert(obj_symbol.index().0);
127-
if diff_side == DiffSide::Base && let Some(target_symbol) = object.symbol_by_name(prefix) {
128+
if diff_side == DiffSide::Base
129+
&& let Some(target_symbol) = object.symbol_by_name(prefix)
130+
{
128131
ignored_symbols.insert(target_symbol.index().0);
129132
}
130133
}

objdiff-core/src/arch/mod.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,13 @@ use object::Endian as _;
1717

1818
use crate::{
1919
diff::{
20-
display::{ContextItem, HoverItem, InstructionPart}, DiffObjConfig
20+
DiffObjConfig,
21+
display::{ContextItem, HoverItem, InstructionPart},
2122
},
2223
obj::{
23-
DiffSide, FlowAnalysisResult, InstructionArg, InstructionRef, Object, ParsedInstruction, Relocation, RelocationFlags, ResolvedInstructionRef, ResolvedSymbol, Section, Symbol, SymbolFlagSet, SymbolKind
24+
DiffSide, FlowAnalysisResult, InstructionArg, InstructionRef, Object, ParsedInstruction,
25+
Relocation, RelocationFlags, ResolvedInstructionRef, ResolvedSymbol, Section, Symbol,
26+
SymbolFlagSet, SymbolKind,
2427
},
2528
util::ReallySigned,
2629
};

objdiff-core/src/jobs/objdiff.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@ use time::OffsetDateTime;
55
use typed_path::Utf8PlatformPathBuf;
66

77
use crate::{
8-
build::{run_make, BuildConfig, BuildStatus},
9-
diff::{diff_objs, DiffObjConfig, MappingConfig, ObjectDiff},
10-
jobs::{start_job, update_status, Job, JobContext, JobResult, JobState},
11-
obj::{read, DiffSide, Object},
8+
build::{BuildConfig, BuildStatus, run_make},
9+
diff::{DiffObjConfig, MappingConfig, ObjectDiff, diff_objs},
10+
jobs::{Job, JobContext, JobResult, JobState, start_job, update_status},
11+
obj::{DiffSide, Object, read},
1212
};
1313

1414
pub struct ObjDiffConfig {

objdiff-core/src/obj/read.rs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ use anyhow::{Context, Result, anyhow, bail, ensure};
1111
use object::{Object as _, ObjectSection as _, ObjectSymbol as _};
1212

1313
use crate::{
14-
arch::{new_arch, Arch, RelocationOverride, RelocationOverrideTarget},
14+
arch::{Arch, RelocationOverride, RelocationOverrideTarget, new_arch},
1515
diff::DiffObjConfig,
1616
obj::{
17-
split_meta::{SplitMeta, SPLITMETA_SECTION}, DiffSide, FlowAnalysisResult, Object, Relocation, RelocationFlags, Section, SectionData, SectionFlag, SectionKind, Symbol, SymbolFlag, SymbolKind
17+
DiffSide, FlowAnalysisResult, Object, Relocation, RelocationFlags, Section, SectionData,
18+
SectionFlag, SectionKind, Symbol, SymbolFlag, SymbolKind,
19+
split_meta::{SPLITMETA_SECTION, SplitMeta},
1820
},
1921
util::{align_data_slice_to, align_u64_to, read_u16, read_u32},
2022
};
@@ -923,7 +925,11 @@ fn do_combine_sections(
923925
}
924926

925927
#[cfg(feature = "std")]
926-
pub fn read(obj_path: &std::path::Path, config: &DiffObjConfig, diff_side: DiffSide) -> Result<Object> {
928+
pub fn read(
929+
obj_path: &std::path::Path,
930+
config: &DiffObjConfig,
931+
diff_side: DiffSide,
932+
) -> Result<Object> {
927933
let (data, timestamp) = {
928934
let file = std::fs::File::open(obj_path)?;
929935
let timestamp = filetime::FileTime::from_last_modification_time(&file.metadata()?);

0 commit comments

Comments
 (0)