More minor changes

Author: encounter

objdiff-core/src/arch/ppc/flow_analysis.rs

@@ -2,7 +2,7 @@ use alloc::{
     boxed::Box,
     collections::{BTreeMap, BTreeSet},
     format,
-    string::String,
+    string::{String, ToString},
     vec::Vec,
 };
 use core::{

objdiff-gui/src/views/diff.rs

@@ -284,15 +284,19 @@ pub fn diff_view_ui(
 
             // Only need to check the first Object. Technically the first could not have a flow analysis
             // result while the second does but we don't want to waste space on two separate checkboxes.
-            if result.first_obj.as_ref().is_some_and(|(first, _)| first.has_flow_analysis_result())
+            if state.current_view == View::FunctionDiff
+                && result
+                    .first_obj
+                    .as_ref()
+                    .is_some_and(|(first, _)| first.has_flow_analysis_result())
             {
-                let mut placeholder = diff_config.show_data_flow;
+                let mut value = diff_config.show_data_flow;
                 if ui
-                    .checkbox(&mut placeholder, "Show data flow")
+                    .checkbox(&mut value, "Show data flow")
                     .on_hover_text("Show data flow analysis results in place of register names")
                     .clicked()
                 {
-                    ret = Some(DiffViewAction::ToggleShowDataFlow);
+                    ret = Some(DiffViewAction::SetShowDataFlow(value));
                 }
             }
         } else if column == 1 {

objdiff-gui/src/views/symbol_diff.rs

@@ -79,8 +79,8 @@ pub enum DiffViewAction {
     SetMapping(usize, usize),
     /// Set the show_mapped_symbols flag
     SetShowMappedSymbols(bool),
-    /// Toggle the show_data_flow flag
-    ToggleShowDataFlow,
+    /// Set the show_data_flow flag
+    SetShowDataFlow(bool),
 }
 
 #[derive(Debug, Clone, Default, Eq, PartialEq)]
@@ -352,12 +352,11 @@ impl DiffViewState {
             DiffViewAction::SetShowMappedSymbols(value) => {
                 self.symbol_state.show_mapped_symbols = value;
             }
-            DiffViewAction::ToggleShowDataFlow => {
+            DiffViewAction::SetShowDataFlow(value) => {
                 let Ok(mut state) = state.write() else {
                     return;
                 };
-                state.config.diff_obj_config.show_data_flow =
-                    !state.config.diff_obj_config.show_data_flow;
+                state.config.diff_obj_config.show_data_flow = value;
             }
         }
     }